TimeProfile addition/subtraction

[Zetison]

Can support for addition and subtraction for TimeProfile's be added?

One could implement this by

+(a::FixedProfile{T}, b::FixedProfile{T}) where {T} = FixedProfile(a.val + b.val)
function +(a::OperationalProfile{T}, b::OperationalProfile{T}) where {T}
    return OperationalProfile(a.vals .+ b.vals)
end
function +(a::StrategicProfile{T}, b::StrategicProfile{T}) where {T}
    return StrategicProfile(a.vals .+ b.vals)
end
function +(a::ScenarioProfile{T}, b::ScenarioProfile{T}) where {T}
    return ScenarioProfile(a.vals .+ b.vals)
end
function +(a::RepresentativeProfile{T}, b::RepresentativeProfile{T}) where {T}
    return RepresentativeProfile(a.vals .+ b.vals)
end

-(a::TimeProfile{T}, b::TimeProfile{T}) where {T} = a + (-b)

or one could implement length(::TimeProfile) and iterate(::TimeProfile) with the .+ and .- convention.

[JulStraus]

The proposed approach would work at least the way I see it. What are your thoughts @trulsf ? I do not see any issue with incorporating these, except for cases in which the profiles have different lengths.

In this case, we would need to have also @assert to check that the profiles have the same length. The error message for different length is:

prof_1 = OperationalProfile([1, 2, 3])
prof_2 = OperationalProfile([1, 2, 3, 6])

prof_1 + prof_2

ERROR: DimensionMismatch: arrays could not be broadcast to a common size: a has axes Base.OneTo(3) and b has axes Base.OneTo(4)

Do we consider the error message to be sufficiently descriptive?