The resolves and rejects assertions diverge from the naming convention use by Sinon assertions. In Sinon, resolves and rejects are used to program a stub or a fake, e.g. sinon.fake.resolves(42). The Sinon assertions to verify promises are sinon.assert.resolved(...) and sinon.assert.rejected(...).
I would therefore like to propose changing the names as follows:
resolves -> resolvedrejects -> rejectedtoResolveWith -> toHaveBeenResolvedtoRejectWith -> toHaveBeenRejected
The
resolvesandrejectsassertions diverge from the naming convention use by Sinon assertions. In Sinon,resolvesandrejectsare used to program a stub or a fake, e.g.sinon.fake.resolves(42). The Sinon assertions to verify promises aresinon.assert.resolved(...)andsinon.assert.rejected(...).I would therefore like to propose changing the names as follows:
resolves->resolvedrejects->rejectedtoResolveWith->toHaveBeenResolvedtoRejectWith->toHaveBeenRejected