improvement(files): drop reserved public_share columns until used; sync audit mock

Author: TheodoreSpeaks

apps/sim/app/api/workspaces/[id]/files/[fileId]/share/route.test.ts

@@ -45,8 +45,6 @@ const SHARE = {
   token: 'tok_1',
   url: 'https://sim.ai/f/tok_1',
   isActive: true,
-  accessLevel: 'view' as const,
-  authType: 'public' as const,
   resourceType: 'file' as const,
   resourceId: FILE_ID,
 }

apps/sim/lib/api/contracts/public-shares.ts

@@ -3,20 +3,16 @@ import { workspaceIdSchema } from '@/lib/api/contracts/primitives'
 import { defineRouteContract } from '@/lib/api/contracts/types'
 
 export const shareResourceTypeSchema = z.enum(['file', 'folder'])
-export const shareAccessLevelSchema = z.enum(['view', 'edit'])
-export const shareAuthTypeSchema = z.enum(['public', 'password', 'email'])
 
 /**
- * Public-safe representation of a `public_share` row. Never carries the encrypted
- * password or the underlying storage key.
+ * Public-safe representation of a `public_share` row. Never carries the
+ * underlying storage key.
  */
 export const shareRecordSchema = z.object({
   id: z.string(),
   token: z.string(),
   url: z.string(),
   isActive: z.boolean(),
-  accessLevel: shareAccessLevelSchema,
-  authType: shareAuthTypeSchema,
   resourceType: shareResourceTypeSchema,
   resourceId: z.string(),
 })

apps/sim/lib/public-shares/share-manager.ts

@@ -4,19 +4,12 @@ import { createLogger } from '@sim/logger'
 import { generateId, generateShortId } from '@sim/utils/id'
 import { and, eq, inArray } from 'drizzle-orm'
 import type { z } from 'zod'
-import type {
-  ShareRecord,
-  shareAccessLevelSchema,
-  shareAuthTypeSchema,
-  shareResourceTypeSchema,
-} from '@/lib/api/contracts/public-shares'
+import type { ShareRecord, shareResourceTypeSchema } from '@/lib/api/contracts/public-shares'
 import { getBaseUrl } from '@/lib/core/utils/urls'
 
 const logger = createLogger('PublicShareManager')
 
 type ShareResourceType = z.infer<typeof shareResourceTypeSchema>
-type ShareAccessLevel = z.infer<typeof shareAccessLevelSchema>
-type ShareAuthType = z.infer<typeof shareAuthTypeSchema>
 
 type PublicShareRow = typeof publicShare.$inferSelect
 
@@ -31,8 +24,6 @@ function mapShareRecord(row: PublicShareRow): ShareRecord {
     token: row.token,
     url: buildShareUrl(row.token),
     isActive: row.isActive,
-    accessLevel: row.accessLevel as ShareAccessLevel,
-    authType: row.authType as ShareAuthType,
     resourceType: row.resourceType as ShareResourceType,
     resourceId: row.resourceId,
   }

packages/db/migrations/0242_public_share.sql

@@ -6,10 +6,6 @@ CREATE TABLE "public_share" (
 	"created_by" text NOT NULL,
 	"token" text NOT NULL,
 	"is_active" boolean DEFAULT true NOT NULL,
-	"access_level" text DEFAULT 'view' NOT NULL,
-	"auth_type" text DEFAULT 'public' NOT NULL,
-	"password" text,
-	"allowed_emails" json DEFAULT '[]',
 	"created_at" timestamp DEFAULT now() NOT NULL,
 	"updated_at" timestamp DEFAULT now() NOT NULL
 );

packages/db/migrations/meta/0242_snapshot.json

@@ -1,5 +1,5 @@
 {
-  "id": "379b2199-4050-4575-bd20-38fb9bbde6c2",
+  "id": "a99c0c8d-17cb-4153-8888-409e9af9c167",
   "prevId": "f7a9fd28-8bd2-4421-a048-a0a768fc8475",
   "version": "7",
   "dialect": "postgresql",
@@ -10005,33 +10005,6 @@
           "notNull": true,
           "default": true
         },
-        "access_level": {
-          "name": "access_level",
-          "type": "text",
-          "primaryKey": false,
-          "notNull": true,
-          "default": "'view'"
-        },
-        "auth_type": {
-          "name": "auth_type",
-          "type": "text",
-          "primaryKey": false,
-          "notNull": true,
-          "default": "'public'"
-        },
-        "password": {
-          "name": "password",
-          "type": "text",
-          "primaryKey": false,
-          "notNull": false
-        },
-        "allowed_emails": {
-          "name": "allowed_emails",
-          "type": "json",
-          "primaryKey": false,
-          "notNull": false,
-          "default": "'[]'"
-        },
         "created_at": {
           "name": "created_at",
           "type": "timestamp",

packages/db/migrations/meta/_journal.json

@@ -1692,7 +1692,7 @@
     {
       "idx": 242,
       "version": "7",
-      "when": 1781815945803,
+      "when": 1781816705434,
       "tag": "0242_public_share",
       "breakpoints": true
     }

packages/db/schema.ts

@@ -1392,10 +1392,7 @@ export const workspaceFiles = pgTable(
 /**
  * Public share links for workspace resources. Polymorphic on `resourceType` so a
  * single mechanism serves files now and folders later. One row per resource
- * (disable/re-enable flips `isActive` and keeps the same token). `accessLevel`,
- * `authType`, `password`, and `allowedEmails` are reserved for future
- * password/email gating and edit links — v1 honors only `accessLevel='view'` and
- * `authType='public'`.
+ * (disable/re-enable flips `isActive` and keeps the same token).
  */
 export const publicShare = pgTable(
   'public_share',
@@ -1411,10 +1408,6 @@ export const publicShare = pgTable(
       .references(() => user.id, { onDelete: 'cascade' }),
     token: text('token').notNull(),
     isActive: boolean('is_active').notNull().default(true),
-    accessLevel: text('access_level').notNull().default('view'), // 'view' | 'edit' (v1 honors only 'view')
-    authType: text('auth_type').notNull().default('public'), // 'public' | 'password' | 'email' (future)
-    password: text('password'), // encrypted, populated when authType is 'password' (future)
-    allowedEmails: json('allowed_emails').default('[]'), // emails/domains when authType is 'email' (future)
     createdAt: timestamp('created_at').notNull().defaultNow(),
     updatedAt: timestamp('updated_at').notNull().defaultNow(),
   },

packages/testing/src/mocks/audit.mock.ts

@@ -76,6 +76,8 @@ export const auditMock = {
     FILE_DELETED: 'file.deleted',
     FILE_RESTORED: 'file.restored',
     FILE_MOVED: 'file.moved',
+    FILE_SHARED: 'file.shared',
+    FILE_SHARE_DISABLED: 'file.share_disabled',
     FOLDER_CREATED: 'folder.created',
     FOLDER_UPDATED: 'folder.updated',
     FOLDER_DELETED: 'folder.deleted',