address comments

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx

@@ -210,31 +210,23 @@ export const Dropdown = memo(function Dropdown({
     return opts
   }, [fetchOptions, normalizedFetchedOptions, evaluatedOptions, hydratedOption])
 
-  const selectableOptions = useMemo(() => {
-    return allOptions.filter((opt) => typeof opt === 'string' || !opt.hidden)
-  }, [allOptions])
-
   const comboboxOptions = useMemo((): ComboboxOption[] => {
-    return selectableOptions.map((opt) => {
+    return allOptions.map((opt) => {
       if (typeof opt === 'string') {
         return { label: opt.toLowerCase(), value: opt }
       }
       return {
         label: opt.label.toLowerCase(),
         value: opt.id,
         icon: 'icon' in opt ? opt.icon : undefined,
+        hidden: opt.hidden,
       }
     })
-  }, [selectableOptions])
+  }, [allOptions])
 
   const optionMap = useMemo(() => {
-    return new Map(
-      allOptions.map((opt) => {
-        if (typeof opt === 'string') return [opt, opt.toLowerCase()]
-        return [opt.id, opt.label.toLowerCase()]
-      })
-    )
-  }, [allOptions])
+    return new Map(comboboxOptions.map((opt) => [opt.value, opt.label]))
+  }, [comboboxOptions])
 
   const defaultOptionValue = useMemo(() => {
     if (multiSelect) return undefined

apps/sim/components/emcn/components/combobox/combobox.tsx

@@ -45,6 +45,8 @@ const comboboxVariants = cva(
 export type ComboboxOption = {
   label: string
   value: string
+  /** When true, hidden from the picker list but still resolves for display */
+  hidden?: boolean
   /** Icon component to render */
   icon?: React.ComponentType<{ className?: string }>
   /** Pre-rendered icon element (alternative to icon component) */
@@ -207,12 +209,11 @@ const Combobox = memo(
        * Filter options based on current value or search query
        */
       const filteredOptions = useMemo(() => {
-        let result = allOptions
+        let result = allOptions.filter((opt) => !opt.hidden)
 
-        // Filter by editable input value
         if (filterOptions && value && open) {
           const currentValue = value.toString().toLowerCase()
-          const exactMatch = allOptions.find(
+          const exactMatch = result.find(
             (opt) => opt.value === value || opt.label.toLowerCase() === currentValue
           )
           if (!exactMatch) {
@@ -224,7 +225,6 @@ const Combobox = memo(
           }
         }
 
-        // Filter by search query (for searchable mode)
         if (searchable && searchQuery) {
           const query = searchQuery.toLowerCase()
           result = result.filter((option) => {
@@ -242,10 +242,18 @@ const Combobox = memo(
        */
       const filteredGroups = useMemo(() => {
         if (!groups) return null
-        if (!searchable || !searchQuery) return groups
+
+        const baseGroups = groups
+          .map((group) => ({
+            ...group,
+            items: group.items.filter((opt) => !opt.hidden),
+          }))
+          .filter((group) => group.items.length > 0)
+
+        if (!searchable || !searchQuery) return baseGroups
 
         const query = searchQuery.toLowerCase()
-        return groups
+        return baseGroups
           .map((group) => ({
             ...group,
             items: group.items.filter((option) => {

apps/sim/triggers/grain/utils.ts

@@ -39,10 +39,15 @@ export function grainSetupInstructions(eventType: string): string {
 /**
  * Setup instructions for the v2 triggers that correctly explain view-based scoping.
  */
-export function grainV2SetupInstructions(action: string): string {
+export function grainV2SetupInstructions(action: 'item added' | 'item updated' | 'all'): string {
+  const viewSentence =
+    action === 'all'
+      ? 'Enter a Grain <strong>view ID</strong>. Each view has a type &mdash; <em>recordings</em>, <em>highlights</em>, or <em>stories</em> &mdash; and this trigger will fire on every event (added, updated, or removed) for items in that view.'
+      : `Enter a Grain <strong>view ID</strong>. Each view has a type &mdash; <em>recordings</em>, <em>highlights</em>, or <em>stories</em> &mdash; and only items matching that type will fire the <strong>${action}</strong> event.`
+
   const instructions = [
     'Enter your Grain API Key (Personal Access Token). You can find or create one in Grain at <strong>Workspace Settings &gt; API</strong> under Integrations on <a href="https://grain.com/app/settings/integrations?tab=api" target="_blank" rel="noopener noreferrer">grain.com</a>.',
-    `Enter a Grain <strong>view ID</strong>. Each view has a type &mdash; <em>recordings</em>, <em>highlights</em>, or <em>stories</em> &mdash; and only items matching that type will fire the <strong>${action}</strong> event.`,
+    viewSentence,
     'To find your view IDs, use the <strong>List Views</strong> operation on this block or call <code>GET /_/public-api/views</code> directly.',
     'The webhook is created automatically when you save and will be deleted when you remove this trigger.',
   ]