Skip to content

Commit e8f731e

Browse files
committed
fix(sidebar): use useLayoutEffect for attribute removal, remove dead branch
1 parent e6fde83 commit e8f731e

File tree

1 file changed

+7
-4
lines changed
  • apps/sim/app/workspace/[workspaceId]/w/components/sidebar

1 file changed

+7
-4
lines changed

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use client'
22

3-
import { memo, useCallback, useEffect, useMemo, useRef, useState } from 'react'
3+
import { memo, useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react'
44
import { createLogger } from '@sim/logger'
55
import { MoreHorizontal } from 'lucide-react'
66
import Link from 'next/link'
@@ -270,12 +270,17 @@ export const Sidebar = memo(function Sidebar() {
270270

271271
const [showCollapsedContent, setShowCollapsedContent] = useState(isCollapsed)
272272

273+
useLayoutEffect(() => {
274+
if (!isCollapsed) {
275+
document.documentElement.removeAttribute('data-sidebar-collapsed')
276+
}
277+
}, [isCollapsed])
278+
273279
useEffect(() => {
274280
if (isCollapsed) {
275281
const timer = setTimeout(() => setShowCollapsedContent(true), 200)
276282
return () => clearTimeout(timer)
277283
}
278-
document.documentElement.removeAttribute('data-sidebar-collapsed')
279284
setShowCollapsedContent(false)
280285
}, [isCollapsed])
281286

@@ -1087,8 +1092,6 @@ export const Sidebar = memo(function Sidebar() {
10871092
<Loader className='h-[14px] w-[14px]' animate />
10881093
Loading...
10891094
</DropdownMenuItem>
1090-
) : tasks.length === 0 ? (
1091-
<DropdownMenuItem disabled>No tasks yet</DropdownMenuItem>
10921095
) : (
10931096
tasks.map((task) => (
10941097
<DropdownMenuItem key={task.id} asChild>

0 commit comments

Comments
 (0)