fix build, speedup tests by up to 40%

Author: waleedlatif1

apps/sim/app/api/knowledge/search/route.test.ts

@@ -5,12 +5,7 @@
  *
  * @vitest-environment node
  */
-import {
-  createEnvMock,
-  createMockRequest,
-  mockKnowledgeSchemas,
-  requestUtilsMock,
-} from '@sim/testing'
+import { createEnvMock, createMockRequest, requestUtilsMock } from '@sim/testing'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
@@ -61,7 +56,74 @@ vi.mock('drizzle-orm', () => ({
   })),
 }))
 
-mockKnowledgeSchemas()
+vi.mock('@sim/db/schema', () => ({
+  knowledgeBase: {
+    id: 'kb_id',
+    userId: 'user_id',
+    name: 'kb_name',
+    description: 'description',
+    tokenCount: 'token_count',
+    embeddingModel: 'embedding_model',
+    embeddingDimension: 'embedding_dimension',
+    chunkingConfig: 'chunking_config',
+    workspaceId: 'workspace_id',
+    createdAt: 'created_at',
+    updatedAt: 'updated_at',
+    deletedAt: 'deleted_at',
+  },
+  document: {
+    id: 'doc_id',
+    knowledgeBaseId: 'kb_id',
+    filename: 'filename',
+    fileUrl: 'file_url',
+    fileSize: 'file_size',
+    mimeType: 'mime_type',
+    chunkCount: 'chunk_count',
+    tokenCount: 'token_count',
+    characterCount: 'character_count',
+    processingStatus: 'processing_status',
+    processingStartedAt: 'processing_started_at',
+    processingCompletedAt: 'processing_completed_at',
+    processingError: 'processing_error',
+    enabled: 'enabled',
+    tag1: 'tag1',
+    tag2: 'tag2',
+    tag3: 'tag3',
+    tag4: 'tag4',
+    tag5: 'tag5',
+    tag6: 'tag6',
+    tag7: 'tag7',
+    uploadedAt: 'uploaded_at',
+    deletedAt: 'deleted_at',
+  },
+  embedding: {
+    id: 'embedding_id',
+    documentId: 'doc_id',
+    knowledgeBaseId: 'kb_id',
+    chunkIndex: 'chunk_index',
+    content: 'content',
+    embedding: 'embedding',
+    tokenCount: 'token_count',
+    characterCount: 'character_count',
+    tag1: 'tag1',
+    tag2: 'tag2',
+    tag3: 'tag3',
+    tag4: 'tag4',
+    tag5: 'tag5',
+    tag6: 'tag6',
+    tag7: 'tag7',
+    createdAt: 'created_at',
+  },
+  permissions: {
+    id: 'permission_id',
+    userId: 'user_id',
+    entityType: 'entity_type',
+    entityId: 'entity_id',
+    permissionType: 'permission_type',
+    createdAt: 'created_at',
+    updatedAt: 'updated_at',
+  },
+}))
 
 vi.mock('@sim/db', () => ({
   db: mockDbChain,

apps/sim/app/workspace/[workspaceId]/logs/components/logs-toolbar/components/notifications/notifications.tsx

@@ -38,6 +38,7 @@ import {
   useConnectedAccounts,
   useConnectOAuthService,
 } from '@/hooks/queries/oauth/oauth-connections'
+import type { CoreTriggerType } from '@/stores/logs/filters/types'
 import { SlackChannelSelector } from './components/slack-channel-selector'
 import { WorkflowSelector } from './components/workflow-selector'
 
@@ -427,7 +428,7 @@ export const NotificationSettings = memo(function NotificationSettings({
       workflowIds: formData.workflowIds,
       allWorkflows: formData.allWorkflows,
       levelFilter: formData.levelFilter,
-      triggerFilter: formData.triggerFilter,
+      triggerFilter: formData.triggerFilter as CoreTriggerType[],
       includeFinalOutput: formData.includeFinalOutput,
       // Trace spans only available for webhooks (too large for email/Slack)
       includeTraceSpans: activeTab === 'webhook' ? formData.includeTraceSpans : false,

apps/sim/lib/core/config/redis.test.ts

@@ -14,20 +14,27 @@ vi.mock('ioredis', () => ({
   default: MockRedisConstructor,
 }))
 
+import {
+  closeRedisConnection,
+  getRedisClient,
+  onRedisReconnect,
+  resetForTesting,
+} from '@/lib/core/config/redis'
+
 describe('redis config', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     vi.useFakeTimers()
+    resetForTesting()
+    MockRedisConstructor.mockImplementation(() => mockRedisInstance)
   })
 
   afterEach(() => {
     vi.useRealTimers()
-    vi.resetModules()
   })
 
   describe('onRedisReconnect', () => {
     it('should register and invoke reconnect listeners', async () => {
-      const { onRedisReconnect, getRedisClient } = await import('@/lib/core/config/redis')
       const listener = vi.fn()
       onRedisReconnect(listener)
 
@@ -41,7 +48,6 @@ describe('redis config', () => {
     })
 
     it('should not invoke listeners when PINGs succeed', async () => {
-      const { onRedisReconnect, getRedisClient } = await import('@/lib/core/config/redis')
       const listener = vi.fn()
       onRedisReconnect(listener)
 
@@ -56,7 +62,6 @@ describe('redis config', () => {
     })
 
     it('should reset failure count on successful PING', async () => {
-      const { onRedisReconnect, getRedisClient } = await import('@/lib/core/config/redis')
       const listener = vi.fn()
       onRedisReconnect(listener)
 
@@ -74,7 +79,6 @@ describe('redis config', () => {
     })
 
     it('should call disconnect(true) after 2 consecutive PING failures', async () => {
-      const { getRedisClient } = await import('@/lib/core/config/redis')
       getRedisClient()
 
       mockRedisInstance.ping.mockRejectedValue(new Error('ETIMEDOUT'))
@@ -87,7 +91,6 @@ describe('redis config', () => {
     })
 
     it('should handle listener errors gracefully without breaking health check', async () => {
-      const { onRedisReconnect, getRedisClient } = await import('@/lib/core/config/redis')
       const badListener = vi.fn(() => {
         throw new Error('listener crashed')
       })
@@ -107,7 +110,6 @@ describe('redis config', () => {
 
   describe('closeRedisConnection', () => {
     it('should clear the PING interval', async () => {
-      const { getRedisClient, closeRedisConnection } = await import('@/lib/core/config/redis')
       getRedisClient()
 
       mockRedisInstance.quit.mockResolvedValue('OK')
@@ -120,23 +122,20 @@ describe('redis config', () => {
   })
 
   describe('retryStrategy', () => {
-    async function captureRetryStrategy(): Promise<(times: number) => number> {
-      vi.resetModules()
-
+    function captureRetryStrategy(): (times: number) => number {
       let capturedConfig: Record<string, unknown> = {}
       MockRedisConstructor.mockImplementation((_url: string, config: Record<string, unknown>) => {
         capturedConfig = config
         return { ping: vi.fn(), on: vi.fn() }
       })
 
-      const { getRedisClient } = await import('@/lib/core/config/redis')
       getRedisClient()
 
       return capturedConfig.retryStrategy as (times: number) => number
     }
 
-    it('should use exponential backoff with jitter', async () => {
-      const retryStrategy = await captureRetryStrategy()
+    it('should use exponential backoff with jitter', () => {
+      const retryStrategy = captureRetryStrategy()
       expect(retryStrategy).toBeDefined()
 
       const delay1 = retryStrategy(1)
@@ -152,8 +151,8 @@ describe('redis config', () => {
       expect(delay5).toBeLessThanOrEqual(13000)
     })
 
-    it('should cap at 30s for attempts beyond 10', async () => {
-      const retryStrategy = await captureRetryStrategy()
+    it('should cap at 30s for attempts beyond 10', () => {
+      const retryStrategy = captureRetryStrategy()
       expect(retryStrategy(11)).toBe(30000)
       expect(retryStrategy(100)).toBe(30000)
     })

apps/sim/lib/core/config/redis.ts

@@ -194,3 +194,17 @@ export async function closeRedisConnection(): Promise<void> {
     }
   }
 }
+
+/**
+ * Reset all module-level state. Only intended for use in tests.
+ */
+export function resetForTesting(): void {
+  if (pingInterval) {
+    clearInterval(pingInterval)
+    pingInterval = null
+  }
+  globalRedisClient = null
+  pingFailures = 0
+  pingInFlight = false
+  reconnectListeners.length = 0
+}