fix(memories): simplified memories, added memories subblock for agent (#432)

* fix(memories): simplified memories, added memories subblock for agent

* removed raw data from memory block, simplified memory config

* fix(persistence): persist collapsed state for responseFormat code subblock (#429)

* fix(persistence): persist collapsed state for responseFormat code subblock

* add additional type safety

* acknowledged PR comments

Author: waleedlatif1

apps/docs/content/docs/tools/memory.mdx

@@ -43,17 +43,15 @@ Create persistent storage for data that needs to be accessed across multiple wor
 
 ### `memory_add`
 
-Add a new memory to the database or append to existing memory with the same ID. When appending to existing memory, the memory types must match.
+Add a new memory to the database or append to existing memory with the same ID.
 
 #### Input
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
 | `id` | string | Yes | Identifier for the memory. If a memory with this ID already exists, the new data will be appended to it. |
-| `type` | string | Yes | Type of memory \(agent or raw\) |
-| `role` | string | No | Role for agent memory \(user, assistant, or system\) |
-| `content` | string | No | Content for agent memory |
-| `rawData` | json | No | Raw data to store \(JSON format\) |
+| `role` | string | Yes | Role for agent memory \(user, assistant, or system\) |
+| `content` | string | Yes | Content for agent memory |
 
 #### Output
 

apps/sim/app/api/memory/route.ts

@@ -96,8 +96,8 @@ export async function GET(request: NextRequest) {
  * POST handler for creating new memories
  * Requires:
  * - key: Unique identifier for the memory (within workflow scope)
- * - type: Memory type ('agent' or 'raw')
- * - data: Memory content (varies by type)
+ * - type: Memory type ('agent')
+ * - data: Memory content (agent message with role and content)
  * - workflowId: ID of the workflow this memory belongs to
  */
 export async function POST(request: NextRequest) {
@@ -124,13 +124,13 @@ export async function POST(request: NextRequest) {
       )
     }
 
-    if (!type || !['agent', 'raw'].includes(type)) {
+    if (!type || type !== 'agent') {
       logger.warn(`[${requestId}] Invalid memory type: ${type}`)
       return NextResponse.json(
         {
           success: false,
           error: {
-            message: 'Valid memory type (agent or raw) is required',
+            message: 'Memory type must be "agent"',
           },
         },
         { status: 400 }
@@ -220,30 +220,20 @@ export async function POST(request: NextRequest) {
         )
       }
 
-      // Handle appending based on memory type
+      // Handle appending for agent type
       let updatedData
 
-      if (type === 'agent') {
-        // For agent type
-        const newMessage = data
-        const existingData = existingMemory[0].data
-
-        // If existing data is an array, append to it
-        if (Array.isArray(existingData)) {
-          updatedData = [...existingData, newMessage]
-        }
-        // If existing data is a single message object, convert to array
-        else {
-          updatedData = [existingData, newMessage]
-        }
-      } else {
-        // For raw type
-        // Merge objects if they're objects, otherwise use the new data
-        if (typeof existingMemory[0].data === 'object' && typeof data === 'object') {
-          updatedData = { ...existingMemory[0].data, ...data }
-        } else {
-          updatedData = data
-        }
+      // For agent type
+      const newMessage = data
+      const existingData = existingMemory[0].data
+
+      // If existing data is an array, append to it
+      if (Array.isArray(existingData)) {
+        updatedData = [...existingData, newMessage]
+      }
+      // If existing data is a single message object, convert to array
+      else {
+        updatedData = [existingData, newMessage]
       }
 
       // Update the existing memory with appended data
@@ -263,7 +253,7 @@ export async function POST(request: NextRequest) {
         workflowId,
         key,
         type,
-        data: type === 'agent' ? (Array.isArray(data) ? data : [data]) : data,
+        data: Array.isArray(data) ? data : [data],
         createdAt: new Date(),
         updatedAt: new Date(),
       }

apps/sim/app/w/[id]/components/control-bar/components/deploy-modal/components/chat-deploy/chat-deploy.tsx

@@ -30,7 +30,6 @@ import { Input } from '@/components/ui/input'
 import { Label } from '@/components/ui/label'
 import { Skeleton } from '@/components/ui/skeleton'
 import { Textarea } from '@/components/ui/textarea'
-import { getNodeEnv } from '@/lib/environment'
 import { createLogger } from '@/lib/logs/console-logger'
 import { getBaseDomain } from '@/lib/urls/utils'
 import { cn } from '@/lib/utils'
@@ -54,10 +53,8 @@ interface ChatDeployProps {
 
 type AuthType = 'public' | 'password' | 'email'
 
-const isDevelopment = getNodeEnv() === 'development'
-
 const getDomainSuffix = (() => {
-  const suffix = isDevelopment ? `.${getBaseDomain()}` : '.simstudio.ai'
+  const suffix = process.env.NODE_ENV === 'development' ? `.${getBaseDomain()}` : '.simstudio.ai'
   return () => suffix
 })()
 

apps/sim/app/w/[id]/components/workflow-block/components/sub-block/hooks/use-sub-block-value.ts

@@ -13,7 +13,8 @@ function handleProviderBasedApiKey(
   blockId: string,
   subBlockId: string,
   modelValue: string | null | undefined,
-  storeValue: any
+  storeValue: any,
+  isModelChange = false
 ) {
   // Only proceed if we have a model selected
   if (!modelValue) return
@@ -25,20 +26,25 @@ function handleProviderBasedApiKey(
   if (!provider || provider === 'ollama') return
 
   const subBlockStore = useSubBlockStore.getState()
+  const isAutoFillEnabled = useGeneralStore.getState().isAutoFillEnvVarsEnabled
 
-  // Try to get a saved API key for this provider
-  const savedValue = subBlockStore.resolveToolParamValue(provider, 'apiKey', blockId)
+  // Try to get a saved API key for this provider (only if auto-fill is enabled)
+  const savedValue = isAutoFillEnabled
+    ? subBlockStore.resolveToolParamValue(provider, 'apiKey', blockId)
+    : null
 
-  // If we have a valid API key, use it
-  if (savedValue && savedValue !== '') {
-    // Always update the value when switching models, even if it appears the same
-    // This handles cases where the field shows masked values but needs to update
-    subBlockStore.setValue(blockId, subBlockId, savedValue)
-  } else {
-    // Always clear the field when switching to a model with no API key
-    // Don't wait for user interaction to clear it
+  // If we have a valid saved API key and auto-fill is enabled, use it
+  if (savedValue && savedValue !== '' && isAutoFillEnabled) {
+    // Only update if the current value is different to avoid unnecessary updates
+    if (storeValue !== savedValue) {
+      subBlockStore.setValue(blockId, subBlockId, savedValue)
+    }
+  } else if (isModelChange && (!storeValue || storeValue === '')) {
+    // Only clear the field when switching models AND the field is already empty
+    // Don't clear existing user-entered values on initial load
     subBlockStore.setValue(blockId, subBlockId, '')
   }
+  // If no saved value and this is initial load, preserve existing value
 }
 
 /**
@@ -237,7 +243,7 @@ export function useSubBlockValue<T = any>(
 
     // Handle different block types
     if (isProviderBasedBlock) {
-      handleProviderBasedApiKey(blockId, subBlockId, modelValue, storeValue)
+      handleProviderBasedApiKey(blockId, subBlockId, modelValue, storeValue, false)
     } else {
       // Normal handling for non-provider blocks
       handleStandardBlockApiKey(blockId, subBlockId, blockType, storeValue)
@@ -263,27 +269,12 @@ export function useSubBlockValue<T = any>(
       // Update the previous model reference
       prevModelRef.current = modelValue
 
-      // For provider-based blocks, always clear the field if needed
-      // But only fill with saved values if auto-fill is enabled
+      // Handle API key auto-fill for model changes
       if (modelValue) {
-        const provider = getProviderFromModel(modelValue)
-
-        // Skip if we couldn't determine a provider
-        if (!provider || provider === 'ollama') return
-
-        const subBlockStore = useSubBlockStore.getState()
-
-        // Check if there's a saved value for this provider
-        const savedValue = subBlockStore.resolveToolParamValue(provider, 'apiKey', blockId)
-
-        if (savedValue && savedValue !== '' && isAutoFillEnvVarsEnabled) {
-          // Only auto-fill if the feature is enabled
-          subBlockStore.setValue(blockId, subBlockId, savedValue)
-        } else {
-          // Always clear immediately when switching to a model with no saved key
-          // or when auto-fill is disabled
-          subBlockStore.setValue(blockId, subBlockId, '')
-        }
+        handleProviderBasedApiKey(blockId, subBlockId, modelValue, storeValue, true)
+      } else {
+        // If no model is selected, clear the API key field
+        useSubBlockStore.getState().setValue(blockId, subBlockId, '')
       }
     }
   }, [

apps/sim/blocks/blocks/agent.ts

@@ -61,25 +61,22 @@ export const AgentBlock: BlockConfig<AgentResponse> = {
       layout: 'full',
       placeholder: 'Enter system prompt...',
       rows: 5,
-      mode: 'basic',
     },
     {
-      id: 'context',
+      id: 'userPrompt',
       title: 'User Prompt',
       type: 'long-input',
       layout: 'full',
       placeholder: 'Enter context or user message...',
       rows: 3,
-      mode: 'basic',
     },
     {
-      id: 'messages',
-      title: 'Messages',
-      type: 'code',
+      id: 'memories',
+      title: 'Memories',
+      type: 'short-input',
       layout: 'full',
+      placeholder: 'Connect memory block output...',
       mode: 'advanced',
-      language: 'javascript',
-      placeholder: '[{"role": "user", "content": "Hello, can you help me with a question?"}]',
     },
     {
       id: 'model',
@@ -236,15 +233,10 @@ export const AgentBlock: BlockConfig<AgentResponse> = {
   },
   inputs: {
     systemPrompt: { type: 'string', required: false },
-    context: { type: 'string', required: false },
+    userPrompt: { type: 'string', required: false },
+    memories: { type: 'json', required: false },
     model: { type: 'string', required: true },
     apiKey: { type: 'string', required: true },
-    messages: {
-      type: 'json',
-      required: false,
-      description:
-        'Array of message objects with role and content fields for advanced chat history control.',
-    },
     responseFormat: {
       type: 'json',
       required: false,

apps/sim/blocks/blocks/memory.ts

@@ -48,19 +48,11 @@ export const MemoryBlock: BlockConfig = {
         }
 
         if (params.operation === 'add') {
-          if (!params.type) {
-            errors.push('Memory type is required for add operation')
-          } else if (params.type === 'agent') {
-            if (!params.role) {
-              errors.push('Role is required for agent memory')
-            }
-            if (!params.content) {
-              errors.push('Content is required for agent memory')
-            }
-          } else if (params.type === 'raw') {
-            if (!params.rawData) {
-              errors.push('Raw data is required for raw memory')
-            }
+          if (!params.role) {
+            errors.push('Role is required for agent memory')
+          }
+          if (!params.content) {
+            errors.push('Content is required for agent memory')
           }
         }
 
@@ -77,14 +69,9 @@ export const MemoryBlock: BlockConfig = {
           const result: Record<string, any> = {
             ...baseResult,
             id: params.id,
-            type: params.type,
-          }
-
-          if (params.type === 'agent') {
-            result.role = params.role
-            result.content = params.content
-          } else if (params.type === 'raw') {
-            result.rawData = params.rawData
+            type: 'agent', // Always agent type
+            role: params.role,
+            content: params.content,
           }
 
           return result
@@ -114,10 +101,8 @@ export const MemoryBlock: BlockConfig = {
   inputs: {
     operation: { type: 'string', required: true },
     id: { type: 'string', required: true },
-    type: { type: 'string', required: false },
     role: { type: 'string', required: false },
     content: { type: 'string', required: false },
-    rawData: { type: 'json', required: false },
   },
   outputs: {
     response: {
@@ -174,21 +159,6 @@ export const MemoryBlock: BlockConfig = {
         value: 'delete',
       },
     },
-    {
-      id: 'type',
-      title: 'Type',
-      type: 'dropdown',
-      layout: 'full',
-      options: [
-        { label: 'Agent', id: 'agent' },
-        { label: 'Raw', id: 'raw' },
-      ],
-      placeholder: 'Select memory type',
-      condition: {
-        field: 'operation',
-        value: 'add',
-      },
-    },
     {
       id: 'role',
       title: 'Role',
@@ -201,12 +171,8 @@ export const MemoryBlock: BlockConfig = {
       ],
       placeholder: 'Select agent role',
       condition: {
-        field: 'type',
-        value: 'agent',
-        and: {
-          field: 'operation',
-          value: 'add',
-        },
+        field: 'operation',
+        value: 'add',
       },
     },
     {
@@ -216,28 +182,8 @@ export const MemoryBlock: BlockConfig = {
       layout: 'full',
       placeholder: 'Enter message content',
       condition: {
-        field: 'type',
-        value: 'agent',
-        and: {
-          field: 'operation',
-          value: 'add',
-        },
-      },
-    },
-    {
-      id: 'rawData',
-      title: 'Raw Data',
-      type: 'code',
-      layout: 'full',
-      language: 'json',
-      placeholder: '{"key": "value"}',
-      condition: {
-        field: 'type',
-        value: 'raw',
-        and: {
-          field: 'operation',
-          value: 'add',
-        },
+        field: 'operation',
+        value: 'add',
       },
     },
   ],