ack PR comments, remove extranoeus logs

Author: waleedlatif1

apps/sim/app/api/workflows/[id]/execute/route.ts

@@ -787,10 +787,9 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
                 }
               : {}
 
-            // Extract per-invocation instance ID and strip from user-visible output
-            const childWorkflowInstanceId: string | undefined =
-              callbackData.output?._childWorkflowInstanceId
-            const instanceData = childWorkflowInstanceId ? { childWorkflowInstanceId } : {}
+            const instanceData = callbackData.childWorkflowInstanceId
+              ? { childWorkflowInstanceId: callbackData.childWorkflowInstanceId }
+              : {}
 
             if (hasError) {
               logger.info(`[${requestId}] ✗ onBlockComplete (error) called:`, {
@@ -830,8 +829,6 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
                 blockName,
                 blockType,
               })
-              const { _childWorkflowInstanceId: _stripped, ...strippedOutput } =
-                callbackData.output ?? {}
               sendEvent({
                 type: 'block:completed',
                 timestamp: new Date().toISOString(),
@@ -842,7 +839,7 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
                   blockName,
                   blockType,
                   input: callbackData.input,
-                  output: strippedOutput,
+                  output: callbackData.output,
                   durationMs: callbackData.executionTime || 0,
                   startedAt: callbackData.startedAt,
                   executionOrder: callbackData.executionOrder,

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/utils.ts

@@ -101,7 +101,9 @@ export function getBlockColor(blockType: string): string {
 }
 
 /**
- * Checks if a block type is a child workflow node
+ * Checks if a block type is a workflow-calling block (calls a child workflow).
+ * Covers both `workflow` (new) and `workflow_input` (legacy) block variants —
+ * both are handled by WorkflowBlockHandler and emit child workflow events.
  */
 export function isWorkflowBlockType(blockType: string): boolean {
   const t = blockType?.toLowerCase()

apps/sim/executor/execution/block-executor.ts

@@ -166,6 +166,9 @@ export class BlockExecutor {
       this.state.setBlockOutput(node.id, normalizedOutput, duration)
 
       if (!isSentinel && blockLog) {
+        const childWorkflowInstanceId = normalizedOutput._childWorkflowInstanceId as
+          | string
+          | undefined
         const displayOutput = filterOutputForLog(block.metadata?.id || '', normalizedOutput, {
           block,
         })
@@ -178,7 +181,8 @@ export class BlockExecutor {
           duration,
           blockLog.startedAt,
           blockLog.executionOrder,
-          blockLog.endedAt
+          blockLog.endedAt,
+          childWorkflowInstanceId
         )
       }
 
@@ -249,9 +253,6 @@ export class BlockExecutor {
       if (error.childWorkflowSnapshotId) {
         errorOutput.childWorkflowSnapshotId = error.childWorkflowSnapshotId
       }
-      if (error.childWorkflowInstanceId) {
-        errorOutput._childWorkflowInstanceId = error.childWorkflowInstanceId
-      }
     }
 
     this.state.setBlockOutput(node.id, errorOutput, duration)
@@ -279,6 +280,9 @@ export class BlockExecutor {
     )
 
     if (!isSentinel && blockLog) {
+      const childWorkflowInstanceId = ChildWorkflowError.isChildWorkflowError(error)
+        ? error.childWorkflowInstanceId
+        : undefined
       const displayOutput = filterOutputForLog(block.metadata?.id || '', errorOutput, { block })
       this.callOnBlockComplete(
         ctx,
@@ -289,7 +293,8 @@ export class BlockExecutor {
         duration,
         blockLog.startedAt,
         blockLog.executionOrder,
-        blockLog.endedAt
+        blockLog.endedAt,
+        childWorkflowInstanceId
       )
     }
 
@@ -458,7 +463,8 @@ export class BlockExecutor {
     duration: number,
     startedAt: string,
     executionOrder: number,
-    endedAt: string
+    endedAt: string,
+    childWorkflowInstanceId?: string
   ): void {
     const blockId = node.metadata?.originalBlockId ?? node.id
     const blockName = block.metadata?.name ?? blockId
@@ -478,6 +484,7 @@ export class BlockExecutor {
           startedAt,
           executionOrder,
           endedAt,
+          childWorkflowInstanceId,
         },
         iterationContext,
         ctx.childWorkflowContext

apps/sim/executor/execution/types.ts

@@ -132,6 +132,8 @@ export interface ContextExtensions {
       startedAt: string
       executionOrder: number
       endedAt: string
+      /** Per-invocation unique ID linking this workflow block execution to its child block events. */
+      childWorkflowInstanceId?: string
     },
     iterationContext?: IterationContext,
     childWorkflowContext?: ChildWorkflowContext

apps/sim/lib/execution/isolated-vm.ts

@@ -619,7 +619,6 @@ function cleanupWorker(workerId: number) {
   workerInfo.activeExecutions = 0
 
   workers.delete(workerId)
-  logger.info('Worker removed from pool', { workerId, poolSize: workers.size })
 }
 
 function resetWorkerIdleTimeout(workerId: number) {
@@ -635,7 +634,6 @@ function resetWorkerIdleTimeout(workerId: number) {
     workerInfo.idleTimeout = setTimeout(() => {
       const w = workers.get(workerId)
       if (w && w.activeExecutions === 0) {
-        logger.info('Cleaning up idle worker', { workerId })
         cleanupWorker(workerId)
       }
     }, WORKER_IDLE_TIMEOUT_MS)

apps/sim/lib/workflows/executor/execution-events.ts

@@ -271,6 +271,7 @@ export function createSSECallbacks(options: SSECallbackOptions) {
       startedAt: string
       executionOrder: number
       endedAt: string
+      childWorkflowInstanceId?: string
     },
     iterationContext?: IterationContext,
     childWorkflowContext?: ChildWorkflowContext
@@ -291,10 +292,9 @@ export function createSSECallbacks(options: SSECallbackOptions) {
         }
       : {}
 
-    // Extract per-invocation instance ID and strip from user-visible output
-    const childWorkflowInstanceId: string | undefined =
-      callbackData.output?._childWorkflowInstanceId
-    const instanceData = childWorkflowInstanceId ? { childWorkflowInstanceId } : {}
+    const instanceData = callbackData.childWorkflowInstanceId
+      ? { childWorkflowInstanceId: callbackData.childWorkflowInstanceId }
+      : {}
 
     if (hasError) {
       sendEvent({
@@ -318,7 +318,6 @@ export function createSSECallbacks(options: SSECallbackOptions) {
         },
       })
     } else {
-      const { _childWorkflowInstanceId: _stripped, ...strippedOutput } = callbackData.output ?? {}
       sendEvent({
         type: 'block:completed',
         timestamp: new Date().toISOString(),
@@ -329,7 +328,7 @@ export function createSSECallbacks(options: SSECallbackOptions) {
           blockName,
           blockType,
           input: callbackData.input,
-          output: strippedOutput,
+          output: callbackData.output,
           durationMs: callbackData.executionTime || 0,
           startedAt: callbackData.startedAt,
           executionOrder: callbackData.executionOrder,