Skip to content

Commit b465a3c

Browse files
authored
fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open (#4977)
* fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open @radix-ui/react-dropdown-menu was the only Radix package pinned exactly (2.1.16), so the v0.7.0 lockfile refresh left its react-menu on focus-scope@1.1.7 + dismissable-layer@1.1.11 while react-dialog@1.1.16 moved to focus-scope@1.1.9 + dismissable-layer@1.1.12. These packages coordinate modal/popper interplay through module-scoped singletons (focusScopesStack, layersWithOutsidePointerEventsDisabled); with two copies in the bundle, a dialog's focus trap never pauses for a menu portaled outside it and yanks focus back as the menu opens, so the menu's dismiss layer unmounts it in the same tick. Symptom: ChipDropdown menus inside ChipModal (e.g. the credential Add People role dropdown) never appear in fresh-install/production builds while stale local installs with a single shared copy keep working. Bump dropdown-menu to 2.1.17, whose react-menu pins the same internals batch as dialog 1.1.16 — every coordination package (dismissable-layer, focus-scope, focus-guards, portal, popper, presence) now resolves to a single version tree-wide. * fix(deps): use caret range for dropdown-menu so radix internals track the same batch Address review: the exact pin was the original divergence mechanism, and the rest of the radix popper/dialog family floats on caret ranges that jump to the same internals batch together on lockfile refreshes.
1 parent 493c64f commit b465a3c

2 files changed

Lines changed: 7 additions & 62 deletions

File tree

apps/sim/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
"@radix-ui/react-checkbox": "^1.1.3",
8383
"@radix-ui/react-collapsible": "^1.1.3",
8484
"@radix-ui/react-dialog": "^1.1.5",
85-
"@radix-ui/react-dropdown-menu": "2.1.16",
85+
"@radix-ui/react-dropdown-menu": "^2.1.17",
8686
"@radix-ui/react-label": "^2.1.2",
8787
"@radix-ui/react-popover": "^1.1.5",
8888
"@radix-ui/react-progress": "^1.1.2",

0 commit comments

Comments
 (0)