Skip to content

Commit b0bedcb

Browse files
committed
fix(ashby): drain response body on delete, clarify decidedAt description
- Cancel unconsumed response body in ok/404 delete branches to free connections - Update decidedAt description to note it's typically null at offer creation
1 parent cfbb293 commit b0bedcb

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

apps/sim/lib/webhooks/provider-subscriptions.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2309,10 +2309,12 @@ export async function deleteAshbyWebhook(webhook: any, requestId: string): Promi
23092309
})
23102310

23112311
if (ashbyResponse.ok) {
2312+
await ashbyResponse.body?.cancel()
23122313
ashbyLogger.info(
23132314
`[${requestId}] Successfully deleted Ashby webhook subscription ${externalId}`
23142315
)
23152316
} else if (ashbyResponse.status === 404) {
2317+
await ashbyResponse.body?.cancel()
23162318
ashbyLogger.info(
23172319
`[${requestId}] Ashby webhook ${externalId} not found during deletion (already removed)`
23182320
)

apps/sim/triggers/ashby/utils.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,11 @@ export function buildOfferCreateOutputs(): Record<string, TriggerOutput> {
224224
description:
225225
'Offer process status (WaitingOnApprovalStart, WaitingOnOfferApproval, WaitingOnCandidateResponse, CandidateAccepted, CandidateRejected, OfferCancelled)',
226226
},
227-
decidedAt: { type: 'string', description: 'Offer decision timestamp (ISO 8601)' },
227+
decidedAt: {
228+
type: 'string',
229+
description:
230+
'Offer decision timestamp (ISO 8601). Typically null at creation; populated after candidate responds.',
231+
},
228232
latestVersion: {
229233
id: { type: 'string', description: 'Latest offer version UUID' },
230234
},

0 commit comments

Comments
 (0)