Skip to content

Commit 9a28f3b

Browse files
committed
fix(attio): use loose null checks to prevent sending null params to API
1 parent ca20d6f commit 9a28f3b

File tree

11 files changed

+24
-24
lines changed

11 files changed

+24
-24
lines changed

apps/sim/tools/attio/create_note.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export const attioCreateNoteTool: ToolConfig<AttioCreateNoteParams, AttioCreateN
8383
content: params.content,
8484
}
8585
if (params.createdAt) body.created_at = params.createdAt
86-
if (params.meetingId !== undefined) body.meeting_id = params.meetingId || null
86+
if (params.meetingId != null) body.meeting_id = params.meetingId || null
8787
return { data: body }
8888
},
8989
},

apps/sim/tools/attio/list_notes.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ export const attioListNotesTool: ToolConfig<AttioListNotesParams, AttioListNotes
5454
const searchParams = new URLSearchParams()
5555
if (params.parentObject) searchParams.set('parent_object', params.parentObject)
5656
if (params.parentRecordId) searchParams.set('parent_record_id', params.parentRecordId)
57-
if (params.limit !== undefined) searchParams.set('limit', String(params.limit))
58-
if (params.offset !== undefined) searchParams.set('offset', String(params.offset))
57+
if (params.limit != null) searchParams.set('limit', String(params.limit))
58+
if (params.offset != null) searchParams.set('offset', String(params.offset))
5959
const qs = searchParams.toString()
6060
return `https://api.attio.com/v2/notes${qs ? `?${qs}` : ''}`
6161
},

apps/sim/tools/attio/list_records.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ export const attioListRecordsTool: ToolConfig<AttioListRecordsParams, AttioListR
7878
body.sorts = params.sorts
7979
}
8080
}
81-
if (params.limit !== undefined) body.limit = params.limit
82-
if (params.offset !== undefined) body.offset = params.offset
81+
if (params.limit != null) body.limit = params.limit
82+
if (params.offset != null) body.offset = params.offset
8383
return body
8484
},
8585
},

apps/sim/tools/attio/list_tasks.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@ export const attioListTasksTool: ToolConfig<AttioListTasksParams, AttioListTasks
7373
if (params.linkedObject) searchParams.set('linked_object', params.linkedObject)
7474
if (params.linkedRecordId) searchParams.set('linked_record_id', params.linkedRecordId)
7575
if (params.assignee) searchParams.set('assignee', params.assignee)
76-
if (params.isCompleted !== undefined) {
76+
if (params.isCompleted != null) {
7777
searchParams.set('is_completed', String(params.isCompleted))
7878
}
7979
if (params.sort) searchParams.set('sort', params.sort)
80-
if (params.limit !== undefined) searchParams.set('limit', String(params.limit))
81-
if (params.offset !== undefined) searchParams.set('offset', String(params.offset))
80+
if (params.limit != null) searchParams.set('limit', String(params.limit))
81+
if (params.offset != null) searchParams.set('offset', String(params.offset))
8282
const qs = searchParams.toString()
8383
return `https://api.attio.com/v2/tasks${qs ? `?${qs}` : ''}`
8484
},

apps/sim/tools/attio/list_threads.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ export const attioListThreadsTool: ToolConfig<AttioListThreadsParams, AttioListT
6767
if (params.object) searchParams.set('object', params.object)
6868
if (params.entryId) searchParams.set('entry_id', params.entryId)
6969
if (params.list) searchParams.set('list', params.list)
70-
if (params.limit !== undefined) searchParams.set('limit', String(params.limit))
71-
if (params.offset !== undefined) searchParams.set('offset', String(params.offset))
70+
if (params.limit != null) searchParams.set('limit', String(params.limit))
71+
if (params.offset != null) searchParams.set('offset', String(params.offset))
7272
const qs = searchParams.toString()
7373
return `https://api.attio.com/v2/threads${qs ? `?${qs}` : ''}`
7474
},

apps/sim/tools/attio/list_webhooks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ export const attioListWebhooksTool: ToolConfig<AttioListWebhooksParams, AttioLis
4141
request: {
4242
url: (params) => {
4343
const searchParams = new URLSearchParams()
44-
if (params.limit !== undefined) searchParams.set('limit', String(params.limit))
45-
if (params.offset !== undefined) searchParams.set('offset', String(params.offset))
44+
if (params.limit != null) searchParams.set('limit', String(params.limit))
45+
if (params.offset != null) searchParams.set('offset', String(params.offset))
4646
const qs = searchParams.toString()
4747
return `https://api.attio.com/v2/webhooks${qs ? `?${qs}` : ''}`
4848
},

apps/sim/tools/attio/query_list_entries.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ export const attioQueryListEntriesTool: ToolConfig<
8383
body.sorts = []
8484
}
8585
}
86-
if (params.limit !== undefined) body.limit = params.limit
87-
if (params.offset !== undefined) body.offset = params.offset
86+
if (params.limit != null) body.limit = params.limit
87+
if (params.offset != null) body.offset = params.offset
8888
return body
8989
},
9090
},

apps/sim/tools/attio/update_list.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ export const attioUpdateListTool: ToolConfig<AttioUpdateListParams, AttioUpdateL
6666
}),
6767
body: (params) => {
6868
const data: Record<string, unknown> = {}
69-
if (params.name !== undefined) data.name = params.name
70-
if (params.apiSlug !== undefined) data.api_slug = params.apiSlug
71-
if (params.workspaceAccess !== undefined) data.workspace_access = params.workspaceAccess
72-
if (params.workspaceMemberAccess !== undefined) {
69+
if (params.name != null) data.name = params.name
70+
if (params.apiSlug != null) data.api_slug = params.apiSlug
71+
if (params.workspaceAccess != null) data.workspace_access = params.workspaceAccess
72+
if (params.workspaceMemberAccess != null) {
7373
try {
7474
data.workspace_member_access =
7575
typeof params.workspaceMemberAccess === 'string'

apps/sim/tools/attio/update_object.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ export const attioUpdateObjectTool: ToolConfig<AttioUpdateObjectParams, AttioUpd
5959
}),
6060
body: (params) => {
6161
const data: Record<string, unknown> = {}
62-
if (params.apiSlug !== undefined) data.api_slug = params.apiSlug
63-
if (params.singularNoun !== undefined) data.singular_noun = params.singularNoun
64-
if (params.pluralNoun !== undefined) data.plural_noun = params.pluralNoun
62+
if (params.apiSlug != null) data.api_slug = params.apiSlug
63+
if (params.singularNoun != null) data.singular_noun = params.singularNoun
64+
if (params.pluralNoun != null) data.plural_noun = params.pluralNoun
6565
return { data }
6666
},
6767
},

apps/sim/tools/attio/update_task.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ export const attioUpdateTaskTool: ToolConfig<AttioUpdateTaskParams, AttioUpdateT
6464
}),
6565
body: (params) => {
6666
const data: Record<string, unknown> = {}
67-
if (params.deadlineAt !== undefined) data.deadline_at = params.deadlineAt || null
68-
if (params.isCompleted !== undefined) data.is_completed = params.isCompleted
67+
if (params.deadlineAt != null) data.deadline_at = params.deadlineAt || null
68+
if (params.isCompleted != null) data.is_completed = params.isCompleted
6969
if (params.linkedRecords) {
7070
try {
7171
data.linked_records =

0 commit comments

Comments
 (0)