Skip to content

Commit 5a8e611

Browse files
waleedlatif1claude
andcommitted
fix(processing): reset completing flag on fallback failure, clean up empty catch
- completeWithCostOnlyLog now resets this.completing = false when the fallback itself fails, preventing a permanently stuck session - Use _disconnectError in MCP test-connection to signal intentional ignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8e72e13 commit 5a8e611

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

apps/sim/app/api/mcp/servers/test-connection/route.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const POST = withMcpAuth('write')(
172172
if (client) {
173173
try {
174174
await client.disconnect()
175-
} catch (disconnectError) {}
175+
} catch (_) {}
176176
}
177177
}
178178

apps/sim/lib/logs/execution/logging-session.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -879,6 +879,7 @@ export class LoggingSession {
879879
`[${this.requestId || 'unknown'}] Cost-only fallback succeeded for execution ${this.executionId}`
880880
)
881881
} catch (fallbackError) {
882+
this.completing = false
882883
logger.error(
883884
`[${this.requestId || 'unknown'}] Cost-only fallback also failed for execution ${this.executionId}:`,
884885
{ error: fallbackError instanceof Error ? fallbackError.message : String(fallbackError) }

0 commit comments

Comments
 (0)