fix(blocks): address PR review — move remaining param mutations from tool() to params()

- Moved field mappings from tool() to params() in grafana, posthog,
  lemlist, spotify, dropbox (same dynamic reference bug)
- Fixed parallel.ts excerpts/full_content boolean logic
- Fixed parallel.ts search_queries empty case (must set undefined)
- Fixed elasticsearch.ts timeout not included when already ends with 's'
- Restored dropbox.ts tool() switch for proper default fallback

Author: waleedlatif1

CLAUDE.md

@@ -246,7 +246,7 @@ export const ServiceBlock: BlockConfig = {
 
 Register in `blocks/registry.ts` (alphabetically).
 
-**IMPORTANT:** `tools.config.tool` runs during serialization (before variable resolution). Never do `Number()` or other type coercions there — dynamic references like `<Block.output>` will be destroyed. Use `tools.config.params` for type coercions (it runs during execution, after variables are resolved).
+**Important:** `tools.config.tool` runs during serialization (before variable resolution). Never do `Number()` or other type coercions there — dynamic references like `<Block.output>` will be destroyed. Use `tools.config.params` for type coercions (it runs during execution, after variables are resolved).
 
 **SubBlock Properties:**
 ```typescript

apps/sim/blocks/blocks/dropbox.ts

@@ -309,12 +309,6 @@ Return ONLY the timestamp string - no explanations, no quotes, no extra text.`,
     ],
     config: {
       tool: (params) => {
-        // Normalize file input for upload operation - use canonical 'file' param
-        const normalizedFile = normalizeFileInput(params.file, { single: true })
-        if (normalizedFile) {
-          params.file = normalizedFile
-        }
-
         switch (params.operation) {
           case 'dropbox_upload':
             return 'dropbox_upload'
@@ -344,6 +338,10 @@ Return ONLY the timestamp string - no explanations, no quotes, no extra text.`,
         const result: Record<string, unknown> = {}
         if (params.limit) result.limit = Number(params.limit)
         if (params.maxResults) result.maxResults = Number(params.maxResults)
+        const normalizedFile = normalizeFileInput(params.file, { single: true })
+        if (normalizedFile) {
+          result.file = normalizedFile
+        }
         return result
       },
     },

apps/sim/blocks/blocks/elasticsearch.ts

@@ -465,9 +465,8 @@ Return ONLY valid JSON - no explanations, no markdown code blocks.`,
         if (params.size) result.size = Number(params.size)
         if (params.from) result.from = Number(params.from)
         if (params.retryOnConflict) result.retryOnConflict = Number(params.retryOnConflict)
-        // Append 's' to timeout for Elasticsearch time format
-        if (params.timeout && typeof params.timeout === 'string' && !params.timeout.endsWith('s')) {
-          result.timeout = `${params.timeout}s`
+        if (params.timeout && typeof params.timeout === 'string') {
+          result.timeout = params.timeout.endsWith('s') ? params.timeout : `${params.timeout}s`
         }
         return result
       },

apps/sim/blocks/blocks/grafana.ts

@@ -606,23 +606,6 @@ Return ONLY the folder title - no explanations, no quotes, no extra text.`,
     ],
     config: {
       tool: (params) => {
-        // Map subblock fields to tool parameter names
-        if (params.alertTitle) {
-          params.title = params.alertTitle
-        }
-        if (params.folderTitle) {
-          params.title = params.folderTitle
-        }
-        if (params.folderUidNew) {
-          params.uid = params.folderUidNew
-        }
-        if (params.annotationTags) {
-          params.tags = params.annotationTags
-        }
-        if (params.annotationDashboardUid) {
-          params.dashboardUid = params.annotationDashboardUid
-        }
-
         return params.operation
       },
       params: (params) => {
@@ -633,6 +616,11 @@ Return ONLY the folder title - no explanations, no quotes, no extra text.`,
         if (params.timeEnd) result.timeEnd = Number(params.timeEnd)
         if (params.from) result.from = Number(params.from)
         if (params.to) result.to = Number(params.to)
+        if (params.alertTitle) result.title = params.alertTitle
+        if (params.folderTitle) result.title = params.folderTitle
+        if (params.folderUidNew) result.uid = params.folderUidNew
+        if (params.annotationTags) result.tags = params.annotationTags
+        if (params.annotationDashboardUid) result.dashboardUid = params.annotationDashboardUid
         return result
       },
     },

apps/sim/blocks/blocks/lemlist.ts

@@ -169,11 +169,6 @@ export const LemlistBlock: BlockConfig<LemlistResponse> = {
     access: ['lemlist_get_activities', 'lemlist_get_lead', 'lemlist_send_email'],
     config: {
       tool: (params) => {
-        // Map filterLeadId to leadId for get_activities tool
-        if (params.filterLeadId) {
-          params.leadId = params.filterLeadId
-        }
-
         switch (params.operation) {
           case 'get_activities':
             return 'lemlist_get_activities'
@@ -189,6 +184,7 @@ export const LemlistBlock: BlockConfig<LemlistResponse> = {
         const result: Record<string, unknown> = {}
         if (params.limit) result.limit = Number(params.limit)
         if (params.offset) result.offset = Number(params.offset)
+        if (params.filterLeadId) result.leadId = params.filterLeadId
         return result
       },
     },

apps/sim/blocks/blocks/parallel.ts

@@ -172,6 +172,8 @@ export const ParallelBlock: BlockConfig<ToolResponse> = {
               .filter((query: string) => query.length > 0)
             if (queries.length > 0) {
               result.search_queries = queries
+            } else {
+              result.search_queries = undefined
             }
           }
           if (params.max_results) result.max_results = Number(params.max_results)
@@ -182,16 +184,8 @@ export const ParallelBlock: BlockConfig<ToolResponse> = {
 
         if (operation === 'extract') {
           result.objective = params.extract_objective
-          result.excerpts =
-            params.excerpts === 'true' || params.excerpts === true
-              ? true
-              : !(params.excerpts === 'false' || params.excerpts === false)
-          result.full_content =
-            params.full_content === 'true' || params.full_content === true
-              ? true
-              : params.full_content === 'false' || params.full_content === false
-                ? false
-                : false
+          result.excerpts = !(params.excerpts === 'false' || params.excerpts === false)
+          result.full_content = params.full_content === 'true' || params.full_content === true
         }
 
         if (operation === 'deep_research') {

apps/sim/blocks/blocks/posthog.ts

@@ -1185,96 +1185,84 @@ Return ONLY the timestamp string - no explanations, no quotes, no extra text.`,
     ],
     config: {
       tool: (params) => {
-        // Map projectIdParam to projectId for get_project operation
+        return params.operation as string
+      },
+      params: (params) => {
+        const result: Record<string, unknown> = {}
+        if (params.limit) result.limit = Number(params.limit)
+        if (params.offset) result.offset = Number(params.offset)
+        if (params.rolloutPercentage) result.rolloutPercentage = Number(params.rolloutPercentage)
+        if (params.responsesLimit) result.responsesLimit = Number(params.responsesLimit)
+
         if (params.operation === 'posthog_get_project' && params.projectIdParam) {
-          params.projectId = params.projectIdParam
+          result.projectId = params.projectIdParam
         }
-
-        // Map personalApiKey to apiKey for all private endpoint tools
         if (params.personalApiKey) {
-          params.apiKey = params.personalApiKey
+          result.apiKey = params.personalApiKey
         }
 
-        // Map featureFlagId to flagId for feature flag operations
         const flagOps = [
           'posthog_get_feature_flag',
           'posthog_update_feature_flag',
           'posthog_delete_feature_flag',
         ]
         if (flagOps.includes(params.operation as string) && params.featureFlagId) {
-          params.flagId = params.featureFlagId
+          result.flagId = params.featureFlagId
         }
 
-        // Map surveyType to type for survey operations
         if (
           (params.operation === 'posthog_create_survey' ||
             params.operation === 'posthog_update_survey') &&
           params.surveyType
         ) {
-          params.type = params.surveyType
+          result.type = params.surveyType
         }
 
-        // Map isStatic for cohorts
         if (params.operation === 'posthog_create_cohort' && params.isStatic !== undefined) {
-          params.is_static = params.isStatic
+          result.is_static = params.isStatic
         }
 
-        // Map dateMarker to date_marker for annotations
         if (params.operation === 'posthog_create_annotation' && params.dateMarker) {
-          params.date_marker = params.dateMarker
+          result.date_marker = params.dateMarker
         }
 
-        // Map propertyType to property_type
         if (params.operation === 'posthog_update_property_definition' && params.propertyType) {
-          params.property_type = params.propertyType
+          result.property_type = params.propertyType
         }
 
-        // Map insightQuery to query for insights
         if (params.operation === 'posthog_create_insight' && params.insightQuery) {
-          params.query = params.insightQuery
+          result.query = params.insightQuery
         }
 
-        // Map insightTags to tags for insights
         if (params.operation === 'posthog_create_insight' && params.insightTags) {
-          params.tags = params.insightTags
+          result.tags = params.insightTags
         }
 
-        // Map distinctIdFilter to distinctId for list_persons
         if (params.operation === 'posthog_list_persons' && params.distinctIdFilter) {
-          params.distinctId = params.distinctIdFilter
+          result.distinctId = params.distinctIdFilter
         }
 
-        // Map experiment date fields
         if (params.operation === 'posthog_create_experiment') {
           if (params.experimentStartDate) {
-            params.startDate = params.experimentStartDate
+            result.startDate = params.experimentStartDate
           }
           if (params.experimentEndDate) {
-            params.endDate = params.experimentEndDate
+            result.endDate = params.experimentEndDate
           }
         }
 
-        // Map survey date fields
         if (
           params.operation === 'posthog_create_survey' ||
           params.operation === 'posthog_update_survey'
         ) {
           if (params.surveyStartDate) {
-            params.startDate = params.surveyStartDate
+            result.startDate = params.surveyStartDate
           }
           if (params.surveyEndDate) {
-            params.endDate = params.surveyEndDate
+            result.endDate = params.surveyEndDate
           }
         }
 
-        return params.operation as string
-      },
-      params: (params) => {
-        const result: Record<string, unknown> = {}
-        if (params.limit) result.limit = Number(params.limit)
-        if (params.offset) result.offset = Number(params.offset)
-        if (params.rolloutPercentage) result.rolloutPercentage = Number(params.rolloutPercentage)
-        if (params.responsesLimit) result.responsesLimit = Number(params.responsesLimit)
         return result
       },
     },

apps/sim/blocks/blocks/spotify.ts

@@ -755,22 +755,6 @@ export const SpotifyBlock: BlockConfig<ToolResponse> = {
     ],
     config: {
       tool: (params) => {
-        // Map followType to type for check_following
-        if (params.followType) {
-          params.type = params.followType
-        }
-        // Map newName to name for update_playlist
-        if (params.newName) {
-          params.name = params.newName
-        }
-        // Map playUris to uris for play
-        if (params.playUris) {
-          params.uris = params.playUris
-        }
-        // Normalize file input for cover image
-        if (params.coverImage !== undefined) {
-          params.coverImage = normalizeFileInput(params.coverImage, { single: true })
-        }
         return params.operation || 'spotify_search'
       },
       params: (params) => {
@@ -781,6 +765,12 @@ export const SpotifyBlock: BlockConfig<ToolResponse> = {
         if (params.insert_before) result.insert_before = Number(params.insert_before)
         if (params.range_length) result.range_length = Number(params.range_length)
         if (params.position_ms) result.position_ms = Number(params.position_ms)
+        if (params.followType) result.type = params.followType
+        if (params.newName) result.name = params.newName
+        if (params.playUris) result.uris = params.playUris
+        if (params.coverImage !== undefined) {
+          result.coverImage = normalizeFileInput(params.coverImage, { single: true })
+        }
         return result
       },
     },