Skip to content

Commit 1cb8a28

Browse files
committed
fix(settings): align skeleton layouts with actual component structures
- Fix list item gap from 12px to 8px across all skeletons (API keys, custom tools, credentials, MCP) - Add OAuth icon placeholder to credential skeleton - Fix credential button group gap from 8px to 4px - Remove incorrect gap-[4px] from credential-sets text column - Rebuild debug skeleton to match real layout (description + input/button row) - Add scrollable wrapper to BYOK skeleton with more representative item count
1 parent f62fddf commit 1cb8a28

File tree

7 files changed

+29
-17
lines changed

7 files changed

+29
-17
lines changed

apps/sim/app/workspace/[workspaceId]/settings/components/api-keys/api-key-skeleton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function ApiKeysSkeleton() {
2828
<Skeleton className='h-[30px] flex-1 rounded-[8px]' />
2929
<Skeleton className='h-[30px] w-[80px] rounded-[6px]' />
3030
</div>
31-
<div className='flex flex-col gap-[12px]'>
31+
<div className='flex flex-col gap-[8px]'>
3232
<ApiKeySkeleton />
3333
<ApiKeySkeleton />
3434
</div>

apps/sim/app/workspace/[workspaceId]/settings/components/byok/byok-skeleton.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,14 @@ export function BYOKSkeleton() {
2828
<Skeleton className='h-[30px] flex-1 rounded-[8px]' />
2929
</div>
3030
<Skeleton className='h-[14px] w-[280px]' />
31-
<div className='flex flex-col gap-[8px]'>
32-
<BYOKKeySkeleton />
33-
<BYOKKeySkeleton />
34-
<BYOKKeySkeleton />
31+
<div className='min-h-0 flex-1 overflow-y-auto'>
32+
<div className='flex flex-col gap-[8px]'>
33+
<BYOKKeySkeleton />
34+
<BYOKKeySkeleton />
35+
<BYOKKeySkeleton />
36+
<BYOKKeySkeleton />
37+
<BYOKKeySkeleton />
38+
</div>
3539
</div>
3640
</div>
3741
)

apps/sim/app/workspace/[workspaceId]/settings/components/credential-sets/credential-sets-skeleton.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export function CredentialSetsSkeleton() {
1515
<div className='flex items-center justify-between'>
1616
<div className='flex items-center gap-[12px]'>
1717
<Skeleton className='h-9 w-9 rounded-[6px]' />
18-
<div className='flex flex-col gap-[4px]'>
18+
<div className='flex flex-col'>
1919
<Skeleton className='h-[14px] w-[120px]' />
2020
<Skeleton className='h-[12px] w-[80px]' />
2121
</div>
@@ -28,7 +28,7 @@ export function CredentialSetsSkeleton() {
2828
<div className='flex items-center justify-between'>
2929
<div className='flex items-center gap-[12px]'>
3030
<Skeleton className='h-9 w-9 rounded-[6px]' />
31-
<div className='flex flex-col gap-[4px]'>
31+
<div className='flex flex-col'>
3232
<Skeleton className='h-[14px] w-[140px]' />
3333
<Skeleton className='h-[12px] w-[100px]' />
3434
</div>

apps/sim/app/workspace/[workspaceId]/settings/components/credentials/credential-skeleton.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,19 @@ import { Skeleton } from '@/components/emcn'
22

33
/**
44
* Skeleton component for credential list items.
5+
* Includes an icon placeholder for OAuth credentials.
56
*/
67
export function CredentialSkeleton() {
78
return (
89
<div className='flex items-center justify-between gap-[12px]'>
9-
<div className='flex min-w-0 flex-col justify-center gap-[1px]'>
10-
<Skeleton className='h-[14px] w-[100px]' />
11-
<Skeleton className='h-[13px] w-[200px]' />
10+
<div className='flex min-w-0 items-center gap-[10px]'>
11+
<Skeleton className='h-8 w-8 flex-shrink-0 rounded-[6px]' />
12+
<div className='flex min-w-0 flex-col justify-center gap-[1px]'>
13+
<Skeleton className='h-[14px] w-[100px]' />
14+
<Skeleton className='h-[13px] w-[200px]' />
15+
</div>
1216
</div>
13-
<div className='flex flex-shrink-0 items-center gap-[8px]'>
17+
<div className='flex flex-shrink-0 items-center gap-[4px]'>
1418
<Skeleton className='h-[30px] w-[54px] rounded-[4px]' />
1519
<Skeleton className='h-[30px] w-[50px] rounded-[4px]' />
1620
</div>
@@ -28,7 +32,7 @@ export function CredentialsSkeleton() {
2832
<Skeleton className='h-[30px] flex-1 rounded-[8px]' />
2933
<Skeleton className='h-[30px] w-[64px] rounded-[6px]' />
3034
</div>
31-
<div className='flex flex-col gap-[12px]'>
35+
<div className='flex flex-col gap-[8px]'>
3236
<CredentialSkeleton />
3337
<CredentialSkeleton />
3438
<CredentialSkeleton />

apps/sim/app/workspace/[workspaceId]/settings/components/custom-tools/custom-tool-skeleton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function CustomToolsSkeleton() {
2828
<Skeleton className='h-[30px] flex-1 rounded-[8px]' />
2929
<Skeleton className='h-[30px] w-[64px] rounded-[6px]' />
3030
</div>
31-
<div className='flex flex-col gap-[12px]'>
31+
<div className='flex flex-col gap-[8px]'>
3232
<CustomToolSkeleton />
3333
<CustomToolSkeleton />
3434
<CustomToolSkeleton />

apps/sim/app/workspace/[workspaceId]/settings/components/debug/debug-skeleton.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,16 @@ import { Skeleton } from '@/components/emcn'
22

33
/**
44
* Skeleton for the Debug section shown during dynamic import loading.
5+
* Matches the layout: description text + input/button row.
56
*/
67
export function DebugSkeleton() {
78
return (
8-
<div className='flex flex-col gap-[8px]'>
9-
<Skeleton className='h-5 w-[200px]' />
10-
<Skeleton className='h-5 w-[140px]' />
9+
<div className='flex h-full flex-col gap-[18px]'>
10+
<Skeleton className='h-[14px] w-[340px]' />
11+
<div className='flex gap-[8px]'>
12+
<Skeleton className='h-9 flex-1 rounded-[6px]' />
13+
<Skeleton className='h-9 w-[80px] rounded-[6px]' />
14+
</div>
1115
</div>
1216
)
1317
}

apps/sim/app/workspace/[workspaceId]/settings/components/mcp/mcp-skeleton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export function McpSkeleton() {
1111
<Skeleton className='h-[30px] flex-1 rounded-[8px]' />
1212
<Skeleton className='h-[30px] w-[64px] rounded-[6px]' />
1313
</div>
14-
<div className='flex flex-col gap-[12px]'>
14+
<div className='flex flex-col gap-[8px]'>
1515
<McpServerSkeleton />
1616
<McpServerSkeleton />
1717
<McpServerSkeleton />

0 commit comments

Comments
 (0)