Skip to content

Commit 18982b8

Browse files
committed
fix(servicenow): address greptile review feedback for offset and displayValue
1 parent 7b6f7c7 commit 18982b8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

apps/sim/blocks/blocks/servicenow.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,12 @@ Output: {"short_description": "Network outage", "description": "Network connecti
143143
title: 'Display Value',
144144
type: 'dropdown',
145145
options: [
146+
{ label: 'Default (not set)', id: '' },
146147
{ label: 'False (sys_id only)', id: 'false' },
147148
{ label: 'True (display value only)', id: 'true' },
148149
{ label: 'All (both)', id: 'all' },
149150
],
151+
value: () => '',
150152
condition: { field: 'operation', value: 'servicenow_read_record' },
151153
description: 'Return display values for reference fields instead of sys_ids',
152154
mode: 'advanced',

apps/sim/tools/servicenow/read_record.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export const readRecordTool: ToolConfig<ServiceNowReadParams, ServiceNowReadResp
109109
queryParams.append('sysparm_limit', params.limit.toString())
110110
}
111111

112-
if (params.offset !== undefined) {
112+
if (params.offset) {
113113
queryParams.append('sysparm_offset', params.offset.toString())
114114
}
115115

0 commit comments

Comments
 (0)