fix(executor): strengthen format detection per PR review

- Add UUID validation on executionId to eliminate false-positive detection
  when user Response block data coincidentally contains success + executionId
- Scope childWorkflowId/childWorkflowName to standard format only so user
  payload fields don't leak into child workflow metadata
- Add test coverage for both edge cases

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/tools/workflow/executor.test.ts

@@ -256,7 +256,7 @@ describe('workflowExecutorTool', () => {
     it.concurrent('should parse standard format response', async () => {
       const body = {
         success: true,
-        executionId: 'exec-123',
+        executionId: '550e8400-e29b-41d4-a716-446655440000',
         output: { result: 'hello' },
         metadata: { duration: 500 },
       }
@@ -272,7 +272,7 @@ describe('workflowExecutorTool', () => {
     it.concurrent('should parse standard format failure', async () => {
       const body = {
         success: false,
-        executionId: 'exec-123',
+        executionId: '550e8400-e29b-41d4-a716-446655440000',
         output: {},
         error: 'Something went wrong',
       }
@@ -336,6 +336,35 @@ describe('workflowExecutorTool', () => {
       expect(result.output).toEqual({ results: [], error: 'No results found' })
       expect(result.error).toBe('No results found')
     })
+
+    it.concurrent(
+      'should not misidentify user data with success + non-UUID executionId as standard format',
+      async () => {
+        const body = { success: true, executionId: 'my-exec-run', data: [1, 2, 3] }
+
+        const result = await transformResponse(mockResponse(body))
+
+        expect(result.success).toBe(true)
+        expect(result.output).toEqual({
+          success: true,
+          executionId: 'my-exec-run',
+          data: [1, 2, 3],
+        })
+      }
+    )
+
+    it.concurrent(
+      'should not leak user payload fields into childWorkflowId/childWorkflowName',
+      async () => {
+        const body = { workflowId: 'user-wf-id', workflowName: 'User WF', data: 'test' }
+
+        const result = await transformResponse(mockResponse(body))
+
+        expect(result.childWorkflowId).toBe('')
+        expect(result.childWorkflowName).toBe('')
+        expect(result.output).toEqual(body)
+      }
+    )
   })
 
   describe('tool metadata', () => {

apps/sim/tools/workflow/executor.ts

@@ -1,6 +1,8 @@
 import type { ToolConfig } from '@/tools/types'
 import type { WorkflowExecutorParams, WorkflowExecutorResponse } from '@/tools/workflow/types'
 
+const UUID_RE = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
+
 /**
  * Tool for executing workflows as blocks within other workflows.
  * This tool is used by the WorkflowBlockHandler to provide the execution capability.
@@ -57,18 +59,20 @@ export const workflowExecutorTool: ToolConfig<
     // The execute endpoint has two response shapes:
     // 1. Standard: { success, executionId, output, error, metadata }
     // 2. Response block: arbitrary user-defined data (no wrapper)
-    // Detect standard format by checking for executionId (always present) + success boolean.
+    // Detect standard format via executionId (always a UUID from uuidv4()) + success boolean.
     const isStandardFormat =
-      typeof data?.success === 'boolean' && typeof data?.executionId === 'string'
+      typeof data?.success === 'boolean' &&
+      typeof data?.executionId === 'string' &&
+      UUID_RE.test(data.executionId)
 
     const outputData = isStandardFormat ? (data.output ?? {}) : data
     const success = isStandardFormat ? data.success : response.ok
 
     return {
       success,
       duration: isStandardFormat ? (data?.metadata?.duration ?? 0) : 0,
-      childWorkflowId: data?.workflowId ?? '',
-      childWorkflowName: data?.workflowName ?? '',
+      childWorkflowId: isStandardFormat ? (data?.workflowId ?? '') : '',
+      childWorkflowName: isStandardFormat ? (data?.workflowName ?? '') : '',
       output: outputData,
       result: outputData,
       error: data?.error,