Replace Psalm with PHPStan

Author: tvdijen

.gitattributes

@@ -5,8 +5,8 @@ codecov.yml export-ignore
 .editorconfig export-ignore
 .gitattributes export-ignore
 .gitignore export-ignore
-psalm.xml export-ignore
-psalm-dev.xml export-ignore
+phpstan.xml export-ignore
+phpstan-dev.xml export-ignore
 phpcs.xml export-ignore
 phpunit.xml export-ignore
 .php_cs.dist export-ignore

.github/workflows/php.yml

@@ -161,9 +161,8 @@ jobs:
         with:
           # Should be the higest supported version, so we can use the newest tools
           php-version: '8.5'
-          tools: composer, composer-require-checker, composer-unused, psalm
-          # optional performance gain for psalm: opcache
-          extensions: ctype, date, dom, fileinfo, filter, hash, intl, mbstring, opcache, openssl, pcre, posix, spl, xml
+          tools: composer, composer-require-checker, composer-unused
+          extensions: ctype, date, dom, fileinfo, filter, hash, intl, mbstring, openssl, pcre, posix, spl, xml
 
       - name: Setup problem matchers for PHP
         run: echo "::add-matcher::${{ runner.tool_cache }}/php.json"
@@ -195,27 +194,13 @@ jobs:
       - name: PHP Code Sniffer
         run: vendor/bin/phpcs
 
-      - name: Psalm
-        continue-on-error: true
-        run: |
-          psalm -c psalm.xml \
-          --show-info=true \
-          --shepherd \
-          --php-version=${{ steps.setup-php.outputs.php-version }}
-
-      - name: Psalm (testsuite)
+      - name: PHPStan
         run: |
-          psalm -c psalm-dev.xml \
-          --show-info=true \
-          --shepherd \
-          --php-version=${{ steps.setup-php.outputs.php-version }}
+          vendor/bin/phpstan analyze -c phpstan.neon --debug
 
-      - name: Psalter
+      - name: PHPStan (testsuite)
         run: |
-          psalm --alter \
-          --issues=UnnecessaryVarAnnotation \
-          --dry-run \
-          --php-version=${{ steps.setup-php.outputs.php-version }}
+          vendor/bin/phpstan analyze -c phpstan-dev.neon --debug
 
   security:
     name: Security checks

phpstan-dev.neon

@@ -0,0 +1,4 @@
+parameters:
+  level: 9
+  paths:
+    - tests

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+  level: 8
+  paths:
+    - src

psalm-dev.xml

@@ -56,7 +56,7 @@ class SmartID extends \SimpleSAML\Auth\ProcessingFilter
 
 
     /**
-     * @param array $config
+     * @param array<mixed> $config
      * @param mixed $reserved
      * @throws \Exception
      */
@@ -107,8 +107,8 @@ public function __construct(array $config, $reserved)
 
 
     /**
-     * @param array $attributes
-     * @param array $request
+     * @param array<mixed> $attributes
+     * @param array<mixed> $request
      * @return string
      * @throws \SimpleSAML\Error\Exception
      */
@@ -150,7 +150,7 @@ private function addID(array $attributes, array $request): string
      *
      * Add or replace existing attributes with the configured values.
      *
-     * @param array &$state  The current request
+     * @param array<mixed> &$state  The current request
      */
     public function process(array &$state): void
     {

psalm.xml

@@ -15,7 +15,7 @@
 class SmartName extends Auth\ProcessingFilter
 {
     /**
-     * @param array $attributes
+     * @param array<mixed> $attributes
      * @return string|null
      */
     private function getFullName(array $attributes): ?string
@@ -79,7 +79,7 @@ private function getLocalUser(string $userid): ?string
      *
      * Add or replace existing attributes with the configured values.
      *
-     * @param array &$state  The current request
+     * @param array<mixed> &$state  The current request
      */
     public function process(array &$state): void
     {