Cleanup inline-css

Author: tvdijen

public/assets/css/metaedit.css

@@ -28,6 +28,7 @@ table.formtable tr td input,table.formtable tr td textarea {
 }
 
 table.metalist {
+    width: 100%;
     border: 1px solid #aaa;
     border-collapse: collapse;
 }
@@ -43,3 +44,21 @@ table.metalist tr.even td {
 p#formedit-right {
     float: right;
 }
+
+#editarea {
+    height: 200px;
+    width: 90%;
+    border: 1px solid #aaa;
+}
+
+#edit-submit {
+    margin-top: 5px;
+}
+
+#import-submit {
+    margin-top: .5em;
+}
+
+span.readonly {
+    color: #aaa;
+}

src/MetaEditor.php

@@ -125,7 +125,7 @@ protected function header(string $name): string
      */
     protected function readonlyDateField(array $metadata, string $key, string $name): string
     {
-        $value = '<span style="color: #aaa">Not set</a>';
+        $value = '<span class="readonly">Not set</a>';
         if (array_key_exists($key, $metadata)) {
             $value = date('j. F Y, G:i', $metadata[$key]);
         }
@@ -253,6 +253,6 @@ public function metaToForm(array $metadata): string
             '</table></div><div id="saml"><table class="formtable">' .
             $this->endpointField($metadata, 'AssertionConsumerService', 'AssertionConsumerService endpoint') .
             $this->endpointField($metadata, 'SingleLogoutService', 'SingleLogoutService endpoint') .
-            '</table></div></div><input type="submit" name="submit" value="Save" style="margin-top: 5px" /></form>';
+            '</table></div></div><input type="submit" id="edit-submit" name="submit" value="Save" /></form>';
     }
 }

templates/metalist.twig

@@ -17,7 +17,7 @@
 
     <h2>Your entries</h2>
 
-    <table class="metalist" style="width: 100%">
+    <table class="metalist">
 
     {% if metadata|length > 0 %}
         <tr><td colspan="3">No entries registered</td></tr>
@@ -42,7 +42,7 @@
     <p><a href="/module.php/metaedit/edit">Add new entity</a> | <a href="/module.php/metaedit/import">Add from SAML 2.0 XML metadata</a></p>
 
     <h2>Other entries</h2>
-    <table class="metalist" style="width: 100%">
+    <table class="metalist">
 
     {% if metadata|length > 0 %}
         <tr><td colspan="3">No entries registered</td></tr>

templates/xmlimport.twig

@@ -6,8 +6,8 @@
 
 <form method="post" action="/edit">
   <p>Paste in SAML 2.0 XML Metadata for the entity that you would like to add.</p>
-  <textarea style="height: 200px; width: 90%; border: 1px solid #aaa;" cols="50" rows="5" name="xmlmetadata"></textarea>
-  <input type="submit" style="margin-top: .5em" name="metasubmit" value="Import metadata" />
+  <textarea id="editarea" cols="50" rows="5" name="xmlmetadata"></textarea>
+  <input type="submit" id="import-submit" name="metasubmit" value="Import metadata" />
 </form>
 
 <p style="float: right"><a href="/module.php/metaedit/">Return to entity listing</a></p>