Skip to content

💡 [FEAT] - Scikit-Lexicographical-Trees into a Longitudinal Splitters Easier Library #86

@simonprovost

Description

@simonprovost

Before Submitting

  • I have checked if this feature already exists or has been requested before.
  • This feature aligns with the goals and scope of Scikit-Longitudinal.

What's the Problem?

Following the great contribution by @MathiasValla to Sklong/Scikit-Lexicographical-Trees, I believe we should entirely rework Scikit-Lexicographical Trees so that it becomes a sklearn-style fork where new splitters and their parameters can be added easily without affecting the others.

For instance, right now, threshold_gain is used as gamma for TpT — can you confirm this, @MathiasValla? This may have made development more straightforward initially, but adding new hyperparameters should be much easier after a full refactor.

As a result, the name could become something along the lines of Scikit-Learn-Longitudinal-Splitters, and Scikit-Lexicographical-Trees might be removed in favour of this new package.

  • Simplification of build
  • Add unit tests to PRs
  • Automation of release tags
  • Easy to add new splitters without new hyper parameters
  • Easy to add new splitters with new hyper parameters
  • Brand new documentation to present each and one of the splitterrs
  • //TO ADD MORE REQUEST IN COMMENT

Cheers

The Dream Solution

N/A

Alternatives

N/A

Context & Relevance

N/A

Screenshots or Additional Material

N/A

Willing to Contribute?

Yes

Metadata

Metadata

Assignees

Labels

ClassificationRelated content to classificationenhancementNew feature or requesthelp wantedExtra attention is needed

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions