Before Submitting
What's the Problem?
Following the great contribution by @MathiasValla to Sklong/Scikit-Lexicographical-Trees, I believe we should entirely rework Scikit-Lexicographical Trees so that it becomes a sklearn-style fork where new splitters and their parameters can be added easily without affecting the others.
For instance, right now, threshold_gain is used as gamma for TpT — can you confirm this, @MathiasValla? This may have made development more straightforward initially, but adding new hyperparameters should be much easier after a full refactor.
As a result, the name could become something along the lines of Scikit-Learn-Longitudinal-Splitters, and Scikit-Lexicographical-Trees might be removed in favour of this new package.
Cheers
The Dream Solution
N/A
Alternatives
N/A
Context & Relevance
N/A
Screenshots or Additional Material
N/A
Willing to Contribute?
Yes
Before Submitting
What's the Problem?
Following the great contribution by @MathiasValla to Sklong/Scikit-Lexicographical-Trees, I believe we should entirely rework Scikit-Lexicographical Trees so that it becomes a sklearn-style fork where new splitters and their parameters can be added easily without affecting the others.
For instance, right now,
threshold_gainis used asgammaforTpT— can you confirm this, @MathiasValla? This may have made development more straightforward initially, but adding new hyperparameters should be much easier after a full refactor.As a result, the name could become something along the lines of
Scikit-Learn-Longitudinal-Splitters, and Scikit-Lexicographical-Trees might be removed in favour of this new package.Cheers
The Dream Solution
N/A
Alternatives
N/A
Context & Relevance
N/A
Screenshots or Additional Material
N/A
Willing to Contribute?
Yes