Dark mode

[sergey-yaroslavtsev]

PyMca is not adapted to dark mode. But users would like to (direct question personally and via email). I Personally also would like.
It seems to me that it looks like some colors are "hardcoded".

Few examples of "bad view":

There are two ways:

1. force light mode - fast and easy
2. correct all the colors - long but better

[sergey-yaroslavtsev]

unfortunately simple:
os.environ["QT_QPA_PLATFORM"] = "windows:darkmode=0"
leads to weird behavior while using Dark mode:

[vasole]

PyMca is not adapted to dark mode. But users would like to (direct question personally and via email). I Personally also would like.
It seems to me that it looks like some colors are "hardcoded".

There are hardcoded colors wherever different colors are used. For instance, in the HDF5 widget, the color changes to blue when there is an NXdata group. Because of that, it wrongly assumes that black is the default.

The same happens in the table. Since the background when there is something special is magenta, it assumes white is the default.

I do not know how many places would need that change. If one could recover the default background or font color instead of assuming they are white or black, the good solution (2nd way) does not look difficult to fix.

[sergey-yaroslavtsev]

Just to notice, if we force Light mode at the beginning then all other changes will be applied afterwards and should take place.

Sorry for stupid question - are colors fixed via palette or differently?
Just to know how to search where the colors are changed.

It will require testing anyway because "default" colors are not always good but should be in most cases. If so later we can just make explicit settings for dark mode if it will be needed.

[t20100]

It's best to get colors from the widget QPalette with color roles, they adapt to dark/light mode.

[sergey-yaroslavtsev]

It's best to get colors from the widget QPalette with color roles, they adapt to dark/light mode.

If i understood correctly it is about not to set a specific color but to set some special ColorRole which will nicely follow the OS theme. Sounds good. If I do understand correctly it should be default behavior (thats why most of PyMca looks OK in dark). But for NXdata group (mentioned by Armando before) as an example it should be set as:

label = QLabel('NXdata group') # or some other object containing the NX group
label.setStyleSheet(f"""
    QLabel {{
        color: {palette.color(QPalette.ColorRole.Link).name()};
    }}
""")

Instead of setting blue explicitly. Do I understand the concept correctly?

My problem with this solution as well as with

I do not know how many places would need that change. If one could recover the default background or font color instead of assuming they are white or black, the good solution (2nd way) does not look difficult to fix.

is how to find all places where the colors were already modified (it seems to be not just few, but maybe i am wrong). That is why i proposed forcing the Light mode as a tmp hot fix.

[t20100]

| If I do understand correctly it should be default behavior (thats why most of PyMca looks OK in dark).

Yes, Qt handles system light/dark mode.

| is how to find all places where the colors were already modified

That's the problem, to be sure you have to open/check all the widgets...
You can search for setColor, setStyleSheet, BackgroundRole, ForegroundRole.. but there's certainly others

[vasole]

Sorry, it was automatically closed when merging #1184

There are not so many places in PyMca where the issue is present. For instance, for HDF5Widget it is enough to do:

to achieve the desired behavior

[vasole]

I think we can consider it closed by #1189

Please feel free to open if it is not the case.