Skip to content

Commit df188c1

Browse files
t20100payno
andauthored
Apply suggestions from code review
Co-authored-by: payno <payno@users.noreply.github.com>
1 parent f009cd4 commit df188c1

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

doc/usage.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,12 @@ Zstd
134134
Get dataset compression
135135
+++++++++++++++++++++++
136136

137-
For compression filters provided by HDF5 and `h5py`_ (i.e., GZIP, LZF, SZIP),
137+
For **built-in** compression filters (i.e., GZIP, LZF, SZIP),
138138
dataset compression configuration can be retrieved with `h5py.Dataset`_'s
139139
`compression <https://docs.h5py.org/en/stable/high/dataset.html#h5py.Dataset.compression>`_ and
140140
`compression_opts <https://docs.h5py.org/en/stable/high/dataset.html#h5py.Dataset.compression_opts>`_ properties.
141141

142-
For third-party compression filters such as the one supported by `hdf5plugin`,
142+
For **third-party** compression filters such as the one supported by `hdf5plugin`,
143143
the dataset compression configuration is stored in HDF5
144144
`filter pipeline <https://docs.h5py.org/en/stable/high/dataset.html#filter-pipeline>`_.
145145
This filter pipeline configuration can be retrieved with `h5py.Dataset`_ "low level" API.

src/hdf5plugin/_filters.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -802,6 +802,8 @@ def _from_filter_options(cls, filter_options: tuple[int, ...]) -> Sperr:
802802
meta=filter_options[0], ret=filter_options[1]
803803
)
804804

805+
if mode == 1:
806+
return cls(rate=quality, swap=swap, missing_value_mode=missing_value_mode)
805807
if mode == 2:
806808
return cls(
807809
peak_signal_to_noise_ratio=quality,
@@ -812,8 +814,7 @@ def _from_filter_options(cls, filter_options: tuple[int, ...]) -> Sperr:
812814
return cls(
813815
absolute=quality, swap=swap, missing_value_mode=missing_value_mode
814816
)
815-
if mode == 1:
816-
return cls(rate=quality, swap=swap, missing_value_mode=missing_value_mode)
817+
817818

818819
raise ValueError(f"Mode must be in [1, 3], got {mode}")
819820

0 commit comments

Comments
 (0)