From 467b618b54f033624c9549a282e8dd00fd47ab33 Mon Sep 17 00:00:00 2001 From: Dmitriy Mironov Date: Thu, 29 Jan 2026 17:19:53 -0300 Subject: [PATCH 1/3] fix: correct loop indices in Connect4 tests for accurate winning detection --- technical-fundamentals/coding/__tests__/connect4.test.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/technical-fundamentals/coding/__tests__/connect4.test.mjs b/technical-fundamentals/coding/__tests__/connect4.test.mjs index 21e1f125..b2208ad5 100644 --- a/technical-fundamentals/coding/__tests__/connect4.test.mjs +++ b/technical-fundamentals/coding/__tests__/connect4.test.mjs @@ -17,7 +17,7 @@ describe("Connect4", () => { it("it should detect horizontal winning", () => { const c4 = new Connect4({ width: 10, height: 10 }); - for (let i = 0; i < 4; i++) { + for (let i = 1; i <= 4; i++) { c4.play(i); c4.play(i); } @@ -26,7 +26,7 @@ describe("Connect4", () => { it("it should detect vertical winning", () => { const c4 = new Connect4({ width: 10, height: 10 }); - for (let i = 0; i < 4; i++) { + for (let i = 1; i <= 4; i++) { c4.play(1); c4.play(2); } From ec2299f9dfc2981de4aad98118324f031aba8f4c Mon Sep 17 00:00:00 2001 From: Dmitriy Mironov Date: Thu, 29 Jan 2026 17:24:57 -0300 Subject: [PATCH 2/3] fix: adjust loop indices in Connect4 tests for correct vertical win detection --- technical-fundamentals/coding/__tests__/connect4.test.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/technical-fundamentals/coding/__tests__/connect4.test.mjs b/technical-fundamentals/coding/__tests__/connect4.test.mjs index b2208ad5..0fecb8d9 100644 --- a/technical-fundamentals/coding/__tests__/connect4.test.mjs +++ b/technical-fundamentals/coding/__tests__/connect4.test.mjs @@ -26,7 +26,7 @@ describe("Connect4", () => { it("it should detect vertical winning", () => { const c4 = new Connect4({ width: 10, height: 10 }); - for (let i = 1; i <= 4; i++) { + for (let i = 0; i < 3; i++) { c4.play(1); c4.play(2); } From 7c3889e8e0a1560b6f632ed714844b39ee39ab72 Mon Sep 17 00:00:00 2001 From: Dmitriy Mironov Date: Thu, 29 Jan 2026 17:25:39 -0300 Subject: [PATCH 3/3] fix: update loop iteration in Connect4 tests to ensure accurate vertical win detection --- technical-fundamentals/coding/__tests__/connect4.test.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/technical-fundamentals/coding/__tests__/connect4.test.mjs b/technical-fundamentals/coding/__tests__/connect4.test.mjs index 0fecb8d9..64cd5898 100644 --- a/technical-fundamentals/coding/__tests__/connect4.test.mjs +++ b/technical-fundamentals/coding/__tests__/connect4.test.mjs @@ -26,7 +26,7 @@ describe("Connect4", () => { it("it should detect vertical winning", () => { const c4 = new Connect4({ width: 10, height: 10 }); - for (let i = 0; i < 3; i++) { + for (let i = 0; i < 4; i++) { c4.play(1); c4.play(2); }