Skip to content

Commit 23568c0

Browse files
authored
Merge pull request #157 from signnow/fix/lock-signing-date
Fix | lock signing date
2 parents 17a84fb + 7046593 commit 23568c0

9 files changed

Lines changed: 29 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,20 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)
55
and this project adheres to [Semantic Versioning](http://semver.org).
66

77
## [Unreleased] - TBD
8+
9+
10+
## [1.2.2] - 2023-08-27
811
### Added
912
- `IEventSubscription` interface for any operation with Events
10-
- Webhooks 2.0 API are implemented
13+
- Webhooks 2.0 API partially implemented
14+
- `ValidatorId` and `LockToSignDate` properties added to the signNow document model (`FieldJsonAttributes`)
1115

1216
### Changed
1317
- Token type is always set to `Bearer` or `Basic` explicitly in every service
1418

19+
### Fixed
20+
- `LockToSignDate` property serialization for Date validator tag
21+
1522

1623
## [1.2.1] - 2023-07-13
1724
### Added
@@ -199,7 +206,8 @@ and this project adheres to [Semantic Versioning](http://semver.org).
199206
[create freeform invite]: https://github.com/signnow/SignNow.NET/blob/develop/README.md#create-freeform-invite
200207

201208
<!-- Links to compare changes from previous version vs new version -->
202-
[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.2.1...HEAD
209+
[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.2.2...HEAD
210+
[1.2.2]: https://github.com/signnow/SignNow.NET/compare/1.2.1...1.2.2
203211
[1.2.1]: https://github.com/signnow/SignNow.NET/compare/1.2.0...1.2.1
204212
[1.2.0]: https://github.com/signnow/SignNow.NET/compare/1.1.1...1.2.0
205213
[1.1.1]: https://github.com/signnow/SignNow.NET/compare/1.1.0...1.1.1

SignNow.Net.Examples/SignNow.Net.Examples.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
</PropertyGroup>
1313

1414
<ItemGroup>
15-
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.1">
15+
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.3">
1616
<PrivateAssets>all</PrivateAssets>
1717
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1818
</PackageReference>
19-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
19+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.1" />
2020
<PackageReference Include="MSTest.TestAdapter" Version="2.2.10" />
2121
<PackageReference Include="MSTest.TestFramework" Version="2.2.10" />
2222
</ItemGroup>

SignNow.Net.Test/SignNow.Net.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
</ItemGroup>
1919

2020
<ItemGroup>
21-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
21+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.1" />
2222
<PackageReference Include="Moq" Version="4.17.2" />
2323
<PackageReference Include="MSTest.TestAdapter" Version="2.2.10" />
2424
<PackageReference Include="MSTest.TestFramework" Version="2.2.10" />

SignNow.Net.Test/TestData/FakeModels/SignNowDocumentFaker.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
using System.IO;
21
using Bogus;
32
using SignNow.Net.Model;
43

SignNow.Net.Test/UnitTests/Models/ComplexTags/ComplexTagsTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ public void ShouldSerializeDateValidatorTag()
220220
""required"": true,
221221
""width"": 100,
222222
""height"": 15,
223-
""lsd"": ""y"",
223+
""lock_to_sign_date"": true,
224224
""validator_id"": ""13435fa6c2a17f83177fcbb5c4a9376ce85befeb""
225225
}";
226226

SignNow.Net/Model/ComplexTags/DateValidatorTag.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ public class DateValidatorTag : ComplexTagWithLabel
1616
/// <summary>
1717
/// Lock Signing Date option
1818
/// </summary>
19-
[JsonProperty("lsd", Order = 1)]
20-
[JsonConverter(typeof(BoolToStringYNJsonConverter))]
19+
[JsonProperty("lock_to_sign_date", Order = 1)]
2120
public bool LockSigningDate { get; set; }
2221

2322
/// <summary>

SignNow.Net/Model/FieldContents/FieldJsonAttributes.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,17 @@ public class FieldJsonAttributes
6060
/// </summary>
6161
[JsonProperty("name")]
6262
public string Name { get; set; }
63+
64+
/// <summary>
65+
/// Use the current date when the recipient is signing the document as a Date field value.
66+
/// </summary>
67+
[JsonProperty("lock_to_sign_date", NullValueHandling = NullValueHandling.Ignore)]
68+
public bool LockToSignDate { get; set; }
69+
70+
/// <summary>
71+
/// ID of regular expression validator supported by signNow.
72+
/// </summary>
73+
[JsonProperty("validator_id", NullValueHandling = NullValueHandling.Ignore)]
74+
public string ValidatorId { get; set; }
6375
}
6476
}

SignNow.Net/SignNow.Net.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<None Include="icon.png" Pack="true" PackagePath="\" />
1818
</ItemGroup>
1919
<ItemGroup>
20-
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.1">
20+
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.3">
2121
<PrivateAssets>all</PrivateAssets>
2222
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2323
</PackageReference>

SignNow.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<PropertyGroup>
3-
<Version>1.2.1-dev</Version>
3+
<Version>1.2.2</Version>
44
<Authors>signNow</Authors>
55
<Company>signNow</Company>
66
<Title>SignNow.NET</Title>

0 commit comments

Comments
 (0)