test: expose source selector hooks#631
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded test instrumentation to source selector components. LaunchWindow's source selector button now has a data-testid for test targeting. SourceSelector derives source kind from the source id and exposes both test ID and source kind as data attributes on the card container. ChangesTest Instrumentation for Source Selector
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This just wires the source picker UI up to the selectors already used by the Windows smoke test. The HUD source button now has the expected test id, and each source card exposes its test id plus whether it came from a screen or window source. No visual/UI behavior changes intended here.\n\nChecked locally:\n- npx.cmd biome check src/components/launch/LaunchWindow.tsx src/components/launch/SourceSelector.tsx\n- npm.cmd run build-vite\n- npm.cmd run test:e2e -- tests/e2e/windows-native-checklist.spec.ts -g " source selector\
Summary by CodeRabbit