Skip to content

Align CI Node and npm versions#534

Open
yusufm wants to merge 1 commit into
siddharthvaddem:mainfrom
yusufm:codex/ci-engine-alignment
Open

Align CI Node and npm versions#534
yusufm wants to merge 1 commit into
siddharthvaddem:mainfrom
yusufm:codex/ci-engine-alignment

Conversation

@yusufm
Copy link
Copy Markdown
Contributor

@yusufm yusufm commented May 3, 2026

Summary

  • pin GitHub Actions to package engine versions: Node 22.22.1 and npm 10.9.4
  • install the pinned npm before npm ci in each CI job
  • fix the linted hook dependency used by CI

Testing

  • npm run lint
  • npx tsc --noEmit

Summary by CodeRabbit

  • Chores

    • Updated CI workflow configuration to centralize Node and npm version management and refined build trigger structure.
  • Refactor

    • Improved internal state management in screen recorder functionality to ensure consistent cleanup and cancellation handling.

@yusufm yusufm requested a review from siddharthvaddem as a code owner May 3, 2026 21:19
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 241ba677-193b-49fc-94d6-4a1a8fe57c85

📥 Commits

Reviewing files that changed from the base of the PR and between 7e00cdb and cabbe71.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • src/hooks/useScreenRecorder.ts

📝 Walkthrough

Walkthrough

CI workflow centralizes Node and npm versions via environment variables and updates job triggers to explicit YAML structure; all jobs now install a specified npm version globally. Separately, a countdown overlay cleanup helper in useScreenRecorder is extracted into a memoized useCallback with proper dependency tracking.

Changes

CI Workflow Configuration

Layer / File(s) Summary
Workflow Triggers
.github/workflows/ci.yml
on: block rewritten from shorthand to explicit pull_request and push triggers with branches: [main] filter.
Version Management
.github/workflows/ci.yml
Environment variables NODE_VERSION: 22.22.1 and NPM_VERSION: 10.9.4 introduced at workflow level.
Job Step Updates
.github/workflows/ci.yml
All four jobs (lint, typecheck, test, build) updated to use ${{ env.NODE_VERSION }} and add npm install -g npm@${{ env.NPM_VERSION }} before package operations.

useScreenRecorder Hook Refactor

Layer / File(s) Summary
Memoized Callback
src/hooks/useScreenRecorder.ts
safeHideCountdownOverlay extracted as a useCallback that wraps window.electronAPI.hideCountdownOverlay with error logging.
Effect Dependencies
src/hooks/useScreenRecorder.ts
Cleanup useEffect updated to include safeHideCountdownOverlay in its dependency array and call the memoized version.
Cleanup
src/hooks/useScreenRecorder.ts
Removes old inline safeHideCountdownOverlay definition; all downstream code now uses the memoized variant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • siddharthvaddem

Poem

npm versions lined up so clean 📦
workflow triggers precise and mean
countdown cleanup memoized right ✨
hooks and ci both polished tonight
duplication fades from sight 🌙

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: aligning CI Node and npm versions. It's specific, concise, and highlights the primary objective.
Description check ✅ Passed The description covers the core changes but lacks several template sections like Motivation, Type of Change, and Testing details beyond command names.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 5/8 reviews remaining, refill in 18 minutes and 23 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant