Refactor note creation and page size handling for dynamic updates

Author: davidwei

lib/providers/note_list_provider.dart

@@ -10,14 +10,6 @@ import '../screens/components/list_grouper.dart';
 
 /// Abstract base class for providers that manage paginated note lists with date grouping
 abstract class NoteListProvider extends AuthAwareProvider {
-  NoteListProvider() {
-    try {
-      _pageSize = AppConfig.pageSize;
-    } catch (e) {
-      _pageSize = 10; // Default for tests
-    }
-  }
-
   // Note list state
   List<Note> _notes = [];
   List<Note> get notes => _notes;
@@ -27,7 +19,9 @@ abstract class NoteListProvider extends AuthAwareProvider {
   int get currentPage => _currentPage;
 
   int _totalNotes = 0;
-  late final int _pageSize;
+
+  // Read pageSize dynamically from AppConfig so setting changes take effect
+  int get _pageSize => AppConfig.pageSize;
 
   // Computed properties
   int get totalPages => _totalNotes <= 0 ? 1 : (_totalNotes / _pageSize).ceil();

lib/providers/tag_notes_provider.dart

@@ -63,6 +63,14 @@ class TagNotesProvider extends NoteListProvider {
     return await _notesService.tagNotes(_currentTag, pageSize, pageNumber);
   }
 
+  /// This is used for optimistic UI updates when creating a note with the current tag
+  void insertNoteIfOnFirstPage(Note note) {
+    if (currentPage == 1) {
+      notes.insert(0, note);
+      notifyListeners();
+    }
+  }
+
   @override
   Future<void> performDelete(int noteId) async {
     await _notesService.delete(noteId);

lib/screens/search/search_results_page.dart

@@ -16,6 +16,8 @@ import 'package:happy_notes/screens/components/floating_pagination.dart';
 import 'package:happy_notes/screens/components/pagination_controls.dart';
 import 'package:happy_notes/screens/components/tappable_app_bar_title.dart';
 import 'package:happy_notes/entities/note.dart';
+import 'package:happy_notes/app_config.dart';
+import 'package:happy_notes/screens/components/create_note_fab.dart';
 
 class SearchResultsPage extends StatefulWidget {
   final String query;
@@ -74,25 +76,6 @@ class _SearchResultsPageState extends State<SearchResultsPage> {
                 );
               },
             ),
-          IconButton(
-            icon: Util.writeNoteIcon(),
-            tooltip: 'New Public Note',
-            onPressed: () async {
-              final scaffoldMessenger = ScaffoldMessenger.of(context);
-              final bool? savedSuccessfully = await Navigator.push<bool>(
-                context,
-                MaterialPageRoute(
-                  builder: (context) => const NewNote(
-                    isPrivate: false,
-                  ),
-                ),
-              );
-              if (savedSuccessfully ?? false) {
-                if (!mounted) return;
-                Util.showInfo(scaffoldMessenger, 'Note saved successfully.');
-              }
-            },
-          ),
         ],
       ),
       body: Consumer<SearchProvider>(
@@ -106,6 +89,22 @@ class _SearchResultsPageState extends State<SearchResultsPage> {
                   totalPages: searchProvider.totalPages,
                   navigateToPage: navigateToPage,
                 ),
+              CreateNoteFAB(
+                isPrivate: AppConfig.privateNoteOnlyIsEnabled,
+                onPressed: () async {
+                  final scaffoldMessenger = ScaffoldMessenger.of(context);
+                  final bool? savedSuccessfully = await Navigator.push<bool>(
+                    context,
+                    MaterialPageRoute(
+                      builder: (context) => NewNote(isPrivate: AppConfig.privateNoteOnlyIsEnabled),
+                    ),
+                  );
+                  if (savedSuccessfully ?? false) {
+                    if (!mounted) return;
+                    Util.showInfo(scaffoldMessenger, 'Note saved successfully.');
+                  }
+                },
+              ),
             ],
           );
         },

lib/screens/tag_notes/tag_notes.dart

@@ -1,6 +1,5 @@
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';
-import 'package:happy_notes/app_config.dart';
 import 'package:happy_notes/screens/note_detail/note_detail.dart';
 import 'package:happy_notes/providers/tag_notes_provider.dart';
 import 'package:happy_notes/providers/note_list_provider.dart';
@@ -15,6 +14,9 @@ import '../account/user_session.dart';
 import '../new_note/new_note.dart';
 import '../components/tappable_app_bar_title.dart';
 import '../../entities/note.dart';
+import 'package:happy_notes/app_config.dart';
+import 'package:happy_notes/screens/components/create_note_fab.dart';
+import 'package:happy_notes/utils/util.dart';
 
 class TagNotes extends StatefulWidget {
   final String tag;
@@ -91,7 +93,6 @@ class TagNotesState extends State<TagNotes> {
               );
             },
           ),
-          _buildNewNoteButton(context),
         ],
       ),
       body: Consumer<TagNotesProvider>(
@@ -105,29 +106,42 @@ class TagNotesState extends State<TagNotes> {
                   totalPages: tagProvider.totalPages,
                   navigateToPage: navigateToPage,
                 ),
+              CreateNoteFAB(
+                isPrivate: AppConfig.privateNoteOnlyIsEnabled,
+                onPressed: () async {
+                  final scaffoldMessenger = ScaffoldMessenger.of(context);
+                  final tagProvider = context.read<TagNotesProvider>();
+                  final Note? savedNote = await Navigator.push<Note>(
+                    context,
+                    MaterialPageRoute(
+                      builder: (context) => NewNote(
+                        isPrivate: AppConfig.privateNoteOnlyIsEnabled,
+                        initialTag: widget.tag,
+                      ),
+                    ),
+                  );
+
+                  if (savedNote != null && mounted) {
+                    // Check if saved note contains the current tag
+                    final noteContainsTag = savedNote.tags?.contains(widget.tag) ?? false;
+
+                    if (noteContainsTag && currentPageNumber == 1) {
+                      // Optimistically insert the note at the top
+                      tagProvider.insertNoteIfOnFirstPage(savedNote);
+                    } else {
+                      // Show success message
+                      Util.showInfo(scaffoldMessenger, 'Note saved successfully.');
+                    }
+                  }
+                },
+              ),
             ],
           );
         },
       ),
     );
   }
 
-  IconButton _buildNewNoteButton(BuildContext context) {
-    return IconButton(
-      icon: const Icon(Icons.edit),
-      onPressed: () async {
-        await Navigator.push(
-          context,
-          MaterialPageRoute(
-            builder: (context) => NewNote(
-              isPrivate: AppConfig.privateNoteOnlyIsEnabled,
-              initialTag: widget.tag,
-            ),
-          ),
-        );
-      },
-    );
-  }
 
   Widget _buildBody() {
     return Consumer<TagNotesProvider>(