-
Notifications
You must be signed in to change notification settings - Fork 47
info pull does not update extension label/description in composer.json or manifest.xml #929
Description
Bug Description
The account producer extension info push command reads the extension label (info.Name) and short description (info.ShortDescription) from composer.json extra.label/extra.description (for platform plugins) or manifest.xml <label>/<description> (for apps) and pushes them to the store API.
However, the account producer extension info pull command fetches info.Name and info.ShortDescription from the store API but silently discards them — they are never written back to composer.json, manifest.xml, or any other local file.
Steps to Reproduce
- Have a published extension with a label set via
composer.jsonextra.label - Change the extension name in the Shopware Store (via the web UI)
- Run
shopware-cli account producer extension info pull <path> - Observe that
composer.jsonextra.labelis not updated with the new name from the store
Expected Behavior
The pull command should update the label and short description in the source file that the push command reads from:
- For platform plugins: update
extra.labelandextra.descriptionincomposer.json - For apps: update
<label>and<description>inmanifest.xml
This would make push and pull symmetric operations.
Actual Behavior
The info.Name and info.ShortDescription fields from the API response are fetched but completely ignored during pull. Only store-specific configuration (tags, images, descriptions, FAQs, etc.) is written to .shopware-extension.yml and src/Resources/store/ files.
Code References
-
Push reads labels at
account_producer_extension_info_push.go:63-74:metadata := zipExt.GetMetaData() for _, info := range storeExt.Infos { language := info.Locale.Name[0:2] if language == "de" { info.Name = metadata.Label.German info.ShortDescription = metadata.Description.German } else { info.Name = metadata.Label.English info.ShortDescription = metadata.Description.English } }
-
Pull at
account_producer_extension_info_pull.go:127-196iterates overstoreExt.Infosbut never usesinfo.Nameorinfo.ShortDescription.