accept Stringables as well as strings

Author: shish

src/microhtml.php

@@ -5,8 +5,8 @@
 namespace MicroHTML;
 
 /**
- * @phpstan-type Attrs array<string,string|null|bool|int|float>
- * @phpstan-type Child \MicroHTML\HTMLElement|string|null|bool|int|float
+ * @phpstan-type Attrs array<string,string|\Stringable|null|bool|int|float>
+ * @phpstan-type Child \MicroHTML\HTMLElement|string|\Stringablenull|bool|int|float
  * @phpstan-type Arg Attrs|Child
  */
 class HTMLElement
@@ -52,10 +52,7 @@ protected function renderAttrs(): string
                 // set to false, which is often easier than deleting
                 // the key from the attributes dictionary
             } else {
-                if (is_numeric($val)) {
-                    $val = (string)$val;
-                }
-                $val = htmlentities($val, ENT_QUOTES, "UTF-8");
+                $val = htmlentities((string)$val, ENT_QUOTES, "UTF-8");
                 $par .= " $name='$val'";
             }
         }
@@ -72,10 +69,7 @@ protected function renderChildren(): string
                 if (is_null($child) || is_bool($child)) {
                     $child = "";
                 }
-                if (is_numeric($child)) {
-                    $child = (string)$child;
-                }
-                $sub .= htmlentities($child, ENT_QUOTES, "UTF-8");
+                $sub .= htmlentities((string)$child, ENT_QUOTES, "UTF-8");
             }
         }
         return $sub;

tests/HTMLElementTest.php

@@ -13,6 +13,14 @@
 use function MicroHTML\rawHTML;
 use function MicroHTML\joinHTML;
 
+class MockUrl
+{
+    public function __toString(): string
+    {
+        return "https://example.com";
+    }
+}
+
 class HTMLElementTest extends \PHPUnit\Framework\TestCase
 {
     /*
@@ -236,4 +244,20 @@ public function testJoinFiltered(): void
             joinHTML(", ", [P("A"), null, "C"], filterNulls: false)
         );
     }
+
+    public function testStringableAttribute(): void
+    {
+        $this->assertEquals(
+            "<a href='https://example.com'>link</a>",
+            A(["href" => new MockUrl()], "link")
+        );
+    }
+
+    public function testStringableChild(): void
+    {
+        $this->assertEquals(
+            "<p>https://example.com</p>",
+            P(new MockUrl())
+        );
+    }
 }