From ebf4408db60ba1e3566dcde6e91a16f7eb318c62 Mon Sep 17 00:00:00 2001 From: Hitesh Garg Date: Wed, 22 Oct 2025 13:41:56 +0530 Subject: [PATCH 1/2] removing redundant code removing redundant code --- sherlock_project/notify.py | 3 --- sherlock_project/result.py | 1 - sherlock_project/sherlock.py | 1 - sherlock_project/sites.py | 2 -- 4 files changed, 7 deletions(-) diff --git a/sherlock_project/notify.py b/sherlock_project/notify.py index f6c785d63..9f14685f1 100644 --- a/sherlock_project/notify.py +++ b/sherlock_project/notify.py @@ -137,7 +137,6 @@ def __init__(self, result=None, verbose=False, print_all=False, browse=False): self.print_all = print_all self.browse = browse - return def start(self, message): """Notify Start. @@ -163,7 +162,6 @@ def start(self, message): # An empty line between first line and the result(more clear output) print('\r') - return def countResults(self): """This function counts the number of results. Every time the function is called, @@ -254,7 +252,6 @@ def update(self, result): f"Unknown Query Status '{result.status}' for site '{self.result.site_name}'" ) - return def finish(self, message="The processing has been finished."): """Notify Start. diff --git a/sherlock_project/result.py b/sherlock_project/result.py index c4d68b1c8..cd23f6da5 100644 --- a/sherlock_project/result.py +++ b/sherlock_project/result.py @@ -69,7 +69,6 @@ def __init__(self, username, site_name, site_url_user, status, self.query_time = query_time self.context = context - return def __str__(self): """Convert Object To String. diff --git a/sherlock_project/sherlock.py b/sherlock_project/sherlock.py index 75b3e3d70..d9e19f197 100644 --- a/sherlock_project/sherlock.py +++ b/sherlock_project/sherlock.py @@ -85,7 +85,6 @@ def response_time(resp, *args, **kwargs): """ resp.elapsed = monotonic() - start - return # Install hook to execute when response completes. # Make sure that the time measurement hook is first, so we will not diff --git a/sherlock_project/sites.py b/sherlock_project/sites.py index b7aaf4c58..9a359af03 100644 --- a/sherlock_project/sites.py +++ b/sherlock_project/sites.py @@ -60,7 +60,6 @@ def __init__(self, name, url_home, url_username_format, username_claimed, self.information = information self.is_nsfw = is_nsfw - return def __str__(self): """Convert Object To String. @@ -208,7 +207,6 @@ def __init__( except TypeError: print(f"Encountered TypeError parsing json contents for target '{site_name}' at {data_file_path}\nSkipping target.\n") - return def remove_nsfw_sites(self, do_not_remove: list = []): """ From 3a67d7abd47a33e6eeef0f6bacac1d14ef1e1676 Mon Sep 17 00:00:00 2001 From: Hitesh Garg Date: Wed, 22 Oct 2025 14:32:50 +0530 Subject: [PATCH 2/2] removing artstation due to false positive removing artstation due to false positive --- docs/removed-sites.md | 12 ++++++++++++ sherlock_project/resources/data.json | 6 ------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/docs/removed-sites.md b/docs/removed-sites.md index b44e520e7..de12dc51c 100644 --- a/docs/removed-sites.md +++ b/docs/removed-sites.md @@ -1995,3 +1995,15 @@ __2025-07-06 :__ Site appears to have gone offline in March and hasn't come back "username_claimed": "GalaxyRG" }, ``` + +## ArtStation +__2025-10-22 :__ ArtStation returns false positives because both existing and non-existing users return HTTP 200 status with empty content. The site appears to be loading content dynamically with JavaScript, making it impossible to distinguish between valid and invalid usernames using the current status_code detection method. + +```json + "ArtStation": { + "errorType": "status_code", + "url": "https://www.artstation.com/{}", + "urlMain": "https://www.artstation.com/", + "username_claimed": "Blue" + } +``` diff --git a/sherlock_project/resources/data.json b/sherlock_project/resources/data.json index 5507c21c8..f6efdcda2 100644 --- a/sherlock_project/resources/data.json +++ b/sherlock_project/resources/data.json @@ -156,12 +156,6 @@ "urlProbe": "https://archive.org/details/@{}?noscript=true", "username_claimed": "blue" }, - "ArtStation": { - "errorType": "status_code", - "url": "https://www.artstation.com/{}", - "urlMain": "https://www.artstation.com/", - "username_claimed": "Blue" - }, "Asciinema": { "errorType": "status_code", "url": "https://asciinema.org/~{}",