When asset is changed inside trade modal, a quote re-fetch should happen for the selected new asset.

[tolltalcrypto]

Overview

When changing an asset inside the app, we do not prompt a quote refresh when the user switches assets.

References and details

https://jam.dev/c/2e3ef7d1-63e5-4431-8e59-7038c953b93d

Acceptance Criteria

The criteria that means the fix is complete. Avoid "it fixes the problem." Include an ideal flow and consult the DAO for input here after making the issue.

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Related PRs

#10138 - fix: avoid asset image blinking on assets page [merged]
#10300 - fix: prevent giant image blow up on asset long press [merged]
#10513 - fix: prevent unecessary calc and rerender on empty upsert asset calls [merged]
#10874 - fix: display primary assets in the market cap section [merged]

👤 Suggested Assignees

• premiumjibles
• NeOMakinG
• JoeChenJ

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

[gomesalexandre]

@tolltalcrypto I think this is more of a product question and is not fundamentally wrong but more a matter of heuristics used here. See Relay vs. Uni vs. 1inch https://jam.dev/c/a84c751c-2afe-4ee4-ab95-4377e4a4cc53

Looks like swappers either:

• reset the sell amount to 0
• keep the sell amount in crypto as-is, which triggers a new quote

We do the first, but both are valid, though with their own issues i.e

• the issue with the first is that, as you've rightfully noted, then you don't have a quote
• the issue with the second is that 1 FOX and 1 BTC have very different fiat rates

Not really opinionated to any and happy to change the heuristics to the second if we really feel like that's better - cc @shapeshift/product @NeOMakinG

Alternatively, we could use fiat prorate when changing sell amount, although as a user would personally feel like too heavy of hand-holding but if we think that's a better option, we could go with that as well!

[JoeChenJ]

@gomesalexandre Looked into and tested the issue, I think the thing here is how the amount is handled when switching assets while inputting fiat amount:

• When the user selects a new asset while inputting the amount in crypto, the amount is reseted, which is the expected behavior.
• However, when the user selects a new asset while inputting the amount in fiat, the fiat amount is not reseted. At the same time, there's no quote re-fetch because the corresponding crypto amount is reseted.

I believe we could take one of the following approaches:

1. Reset the fiat amount as well when the user switches assets.
2. Re-fetch a new quote based on the newly selected asset and the existing fiat amount.

As a user, I personally prefer the second approach as it feels more seamless.

Would love to hear your thoughts!