From aeebf380f1eac4416181047a40d9c20609dbc8d8 Mon Sep 17 00:00:00 2001 From: Mikkel Christensen Date: Wed, 12 Nov 2025 13:20:48 +0100 Subject: [PATCH 1/3] Explicit names for steps in collector job. --- .github/workflows/paths-filtering-tests.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/paths-filtering-tests.yml b/.github/workflows/paths-filtering-tests.yml index 98cea60..9062186 100644 --- a/.github/workflows/paths-filtering-tests.yml +++ b/.github/workflows/paths-filtering-tests.yml @@ -44,9 +44,11 @@ jobs: if: ${{ always() }} runs-on: ubuntu-latest env: - checkPassed: ${{ needs.in-scope.result == 'success' || needs.changes.outputs.inScope != 'true' }} + checksPassed: ${{ needs.in-scope.result == 'success' || needs.changes.outputs.inScope != 'true' }} steps: - - if: ${{ env.checkPassed == 'true' }} + - if: ${{ env.checksPassed == 'true' }} + name: Required Status Checks Passed run: exit 0 - - if: ${{ env.checkPassed == 'false' }} + - if: ${{ env.checksPassed == 'false' }} + name: Required Status Checks Failed run: exit 1 From adafa22f6ce44195d3f09f55d1fc095312aca57e Mon Sep 17 00:00:00 2001 From: Mikkel Christensen Date: Wed, 12 Nov 2025 13:23:49 +0100 Subject: [PATCH 2/3] A slighly more suggestive naming for the collector steps, hinting that they are part of a if-else construct. --- .github/workflows/paths-filtering-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/paths-filtering-tests.yml b/.github/workflows/paths-filtering-tests.yml index 9062186..76e09cf 100644 --- a/.github/workflows/paths-filtering-tests.yml +++ b/.github/workflows/paths-filtering-tests.yml @@ -47,8 +47,8 @@ jobs: checksPassed: ${{ needs.in-scope.result == 'success' || needs.changes.outputs.inScope != 'true' }} steps: - if: ${{ env.checksPassed == 'true' }} - name: Required Status Checks Passed + name: Pass if required checks do run: exit 0 - if: ${{ env.checksPassed == 'false' }} - name: Required Status Checks Failed + name: Fail if required checks do run: exit 1 From cc61bf1da587877e0260c46b5a986d4bc63d7d0a Mon Sep 17 00:00:00 2001 From: Mikkel Christensen Date: Wed, 12 Nov 2025 13:34:51 +0100 Subject: [PATCH 3/3] Attempt with single-step bash-based exit clause branching. --- .github/workflows/paths-filtering-tests.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/paths-filtering-tests.yml b/.github/workflows/paths-filtering-tests.yml index 76e09cf..74d56fd 100644 --- a/.github/workflows/paths-filtering-tests.yml +++ b/.github/workflows/paths-filtering-tests.yml @@ -44,11 +44,12 @@ jobs: if: ${{ always() }} runs-on: ubuntu-latest env: - checksPassed: ${{ needs.in-scope.result == 'success' || needs.changes.outputs.inScope != 'true' }} + checksPassed: >- + ${{ + needs.in-scope.result == 'success' || + needs.changes.outputs.inScope != 'true' + }} steps: - - if: ${{ env.checksPassed == 'true' }} - name: Pass if required checks do - run: exit 0 - - if: ${{ env.checksPassed == 'false' }} - name: Fail if required checks do - run: exit 1 + - name: Pass iff required checks do + run: if [ '${{ env.checksPassed }}' = 'true' ]; then exit 0; else exit 1; fi + shell: bash