Zero division fix when no tasks and no students

setnicka · setnicka · commit 0fe5a9916397 · 2018-02-15T22:56:03.000+01:00
diff --git a/lib/WebTaskSubmitter/View.pm b/lib/WebTaskSubmitter/View.pm
@@ -249,7 +249,8 @@ sub tasklist_page() {
 		$out .= "</tr>\n";
 	}
 
-	my $pp = $student_points/$max_points;
+	my $pp = 0;
+	$pp = $student_points/$max_points if $max_points > 0;
 
 	$out .= sprintf "<tr><th colspan='2'>$texts->{tasklist_total_points}</th><th>%d / %d (%.1f%%)</th><th colspan='2'>%s</th></tr>\n",
 		$student_points, $max_points, $pp * 100,

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,8 @@ sub tasklist_page() {`
`249`	`249`	`$out .= "</tr>\n";`
`250`	`250`	`}`
`251`	`251`
`252`		`- my $pp = $student_points/$max_points;`
	`252`	`+ my $pp = 0;`
	`253`	`+ $pp = $student_points/$max_points if $max_points > 0;`
`253`	`254`
`254`	`255`	`$out .= sprintf "<tr><th colspan='2'>$texts->{tasklist_total_points}</th><th>%d / %d (%.1f%%)</th><th colspan='2'>%s</th></tr>\n",`
`255`	`256`	`$student_points, $max_points, $pp * 100,`