-
Notifications
You must be signed in to change notification settings - Fork 0
feat: store sets of runs as shareable reports #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
serhalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot seems to work, but see feedback
| <input | ||
| :value="generateReportPermalink(currentReportId)" | ||
| readonly | ||
| class="permalink-input" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be much wider as it often contains quite long URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in b38cbb7 - changed max-width from 600px to 100% so the input can expand to show longer URLs.
| <button | ||
| class="copy-button" | ||
| title="Copy to clipboard" | ||
| @click="copyToClipboard(generateReportPermalink(currentReportId))" | ||
| > | ||
| 📋 | ||
| </button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b38cbb7:
- Changed
align-itemsfromcentertostretchto ensure proper vertical alignment - Replaced blue background with white background and 2px blue border (
border: 2px solid var(--blue-600)) - Added
display: flexwithalign-items: centeron button for consistent internal alignment - On hover, button now shows light blue background (
var(--blue-50)) instead of darker blue
… and update UI Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>

Addressing PR feedback comments:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.