fix(openclaw): parse nested SKILL.md frontmatter + hoist metadata.openclaw.web3

[Markeljan]

Summary

The hand-rolled YAML parser in packages/openclaw/src/manifest.ts only handled one level of nesting, so any SKILL.md whose frontmatter declared metadata.openclaw.web3.policy.allowedContracts (the shape recommended in docs/odos-skill-recommendations.md and adopted upstream by odos-xyz/odos-skills) was silently flattened — the parsed manifest ended up with a malformed metadata block and no web3 field. Consequences:

• W04M-003 (no metadata.openclaw) and W04M-004 (no allowedContracts) fired as false positives, even when both fields were correctly declared.
• Every downstream rule that reads manifest.web3.* (AST-W01, AST-W06, AST-W10, AST-W12, etc.) was silently skipped because manifest.web3 was undefined — masking real findings.

What changed

• Replace custom parseYaml with the standard yaml package. Correct handling of arbitrary nesting, block scalars, anchors, and quoted keys — replacing the ~60 LoC single-level scanner that was the root cause.
• Hoist metadata.openclaw.web3 → top-level manifest.web3 during normalization, only when no top-level web3 is declared (top-level wins on conflict). Lets skills follow either canonical layout; every rule keeps reading the same single path.
• Normalize policy.allowedContracts / allowedSelectors from chain-keyed maps ({ 1: ["0x..."], 8453: ["0x..."] }) into deduped flat string[]. Fixes a scanner regression in web3-permit-capture that surfaced once the hoist was wired up (it crashed with allowlistArray.map is not a function on the chain-keyed shape).
• Adds 5 new parser/normalizer tests: deeply-nested SKILL.md frontmatter, hoisting from metadata.openclaw.web3, top-level wins, metadata preservation for AST04, chain-keyed-map flattening.

Verification

Re-audited odos-xyz/odos-skills@93b3db6 with --profile web3:

Finding	Before fix	After fix
W04M-001 (missing license)	already cleared	already cleared
W04M-002 (no permissions)	fires	fires (legitimate — Odos has no permissions array)
W04M-003 (no metadata.openclaw block)	fires (false positive)	cleared ✓
W04M-004 (no allowedContracts)	fires (false positive)	cleared ✓
W12-001 (no audit sink)	not detected (parser masked it)	fires (legitimate)
W12-002 (no kill-switch contract)	not detected (parser masked it)	fires (legitimate)
W12-003 (no incident runbook)	not detected (parser masked it)	fires (legitimate)
SCANNER-ERR web3-permit-capture	crash (regression after hoist)	clean

Score moved from a falsely-flattering 65 (C) to an accurate 47 (D) for the latest Odos commit. The two false-positives Odos was being penalized for now clear; the previously-masked AST-W12 findings (rec #8 in the Odos recommendations doc — not yet shipped upstream) now correctly fire. Re-running the audit against the pre-recommendation commit f88b7c89 is byte-identical to the v0.3.0 baseline (53, same 5 findings), confirming no regression on manifests that don't use the nested shape.

Test plan

• bun run build — 9/9 packages
• bun run test — 17/17 tasks, 95 openclaw tests pass (5 new), 0 failures
• bun run check — typecheck clean
• bun run lint — only pre-existing complexity warnings (unrelated, on other files)
• Re-audit odos-xyz/odos-skills@93b3db6 end-to-end
• Re-audit f88b7c89 (pre-recommendation baseline) — no regression
• Reviewer to spot-check audit output on a non-web3 skill (e.g. e2e/fixtures/good-skill)

🤖 Generated with Claude Code