fix(core): replace btck_ScriptVerificationFlags with a public type alias#185
Merged
Merged
Conversation
sedited
reviewed
May 21, 2026
| c_helpers, ffi::sealed::AsPtr, KernelError, ScriptPubkeyExt, TransactionExt, TxOutExt, | ||
| }; | ||
|
|
||
| pub type ScriptVerificationFlags = btck_ScriptVerificationFlags; |
Owner
There was a problem hiding this comment.
Can we use this in the tests too isntead of its btck_ name? I think that might take an additional export for this module.
Collaborator
Author
There was a problem hiding this comment.
Done - thank you! I also added a doc comment for ScriptVerificationFlags
btck_ScriptVerificationFlags was exposed in the public API via the types on the VERIFY_* constants. Add a ScriptVerificationFlags type alias and update the constants to use it.
alexanderwiederin
force-pushed
the
verify-flags
branch
from
f321e3b to
1676083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
btck_ScriptVerificationFlags was exposed in the public API via the types on the VERIFY_* constants. Add a ScriptVerificationFlags type alias and update the constants to use it.