fix: resolve issue #10 by raising JSONPathTypeError on mixed type sorting

Author: sean2077

jsonpath/__init__.py

@@ -8,6 +8,6 @@
 __version__ = "1.0.6"
 __author__ = "sean2077"
 
-from .jsonpath import ExprSyntaxError, JSONPath, compile, search
+from .jsonpath import ExprSyntaxError, JSONPath, JSONPathTypeError, compile, search
 
-__all__ = ["JSONPath", "ExprSyntaxError", "compile", "search"]
+__all__ = ["JSONPath", "ExprSyntaxError", "JSONPathTypeError", "compile", "search"]

jsonpath/jsonpath.py

@@ -29,6 +29,10 @@ class ExprSyntaxError(Exception):
     pass
 
 
+class JSONPathTypeError(Exception):
+    pass
+
+
 class JSONPath:
     RESULT_TYPE = {
         "VALUE": "A list of specific values.",
@@ -189,14 +193,17 @@ def _getattr(obj: dict, path: str, *, convert_number_str=False):
 
     @staticmethod
     def _sorter(obj, sortbys):
-        for sortby in sortbys.split(",")[::-1]:
-            if sortby.startswith("~"):
-                obj.sort(
-                    key=lambda t, k=sortby: JSONPath._getattr(t[1], k[1:], convert_number_str=True),
-                    reverse=True,
-                )
-            else:
-                obj.sort(key=lambda t, k=sortby: JSONPath._getattr(t[1], k, convert_number_str=True))
+        try:
+            for sortby in sortbys.split(",")[::-1]:
+                if sortby.startswith("~"):
+                    obj.sort(
+                        key=lambda t, k=sortby: JSONPath._getattr(t[1], k[1:], convert_number_str=True),
+                        reverse=True,
+                    )
+                else:
+                    obj.sort(key=lambda t, k=sortby: JSONPath._getattr(t[1], k, convert_number_str=True))
+        except TypeError as e:
+            raise JSONPathTypeError(f"not possible to compare str and int when sorting: {e}") from e
 
     def _filter(self, obj, i: int, path: str, step: str):
         r = False

tests/test_issues.py

@@ -1,4 +1,6 @@
-from jsonpath import JSONPath
+import pytest
+
+from jsonpath import JSONPath, JSONPathTypeError
 
 
 def test_issue_17():
@@ -64,3 +66,38 @@ def test_issue_15_bracket_notation_in_filter():
     # Case 2: Dot notation in filter (already working, but good to keep)
     expr_dot = "$.tool.books.[*].properties.[*].[?(@.name=='moq')].value"
     assert JSONPath(expr_dot).parse(data) == ["x", "q"]
+
+
+def test_issue_10_mixed_type_sorting():
+    # Case 1: Mixed types (int and str) - Should raise JSONPathTypeError
+    data1 = [{"code": "N"}, {"code": 0}]
+    with pytest.raises(JSONPathTypeError):
+        JSONPath("$./(code)").parse(data1)
+
+    # Case 2: Numbers (numerical sort)
+    data2 = [{"code": 10}, {"code": 2}]
+    result2 = JSONPath("$./(code)").parse(data2)
+    assert result2 == [{"code": 2}, {"code": 10}]
+
+    # Case 3: Strings (lexicographical sort)
+    data3 = [{"code": "b"}, {"code": "a"}]
+    result3 = JSONPath("$./(code)").parse(data3)
+    assert result3 == [{"code": "a"}, {"code": "b"}]
+
+    # Case 4: Strings that look like numbers (converted to numbers by _getattr)
+    data4 = [{"code": "10"}, {"code": "2"}]
+    result4 = JSONPath("$./(code)").parse(data4)
+    # "2" -> 2, "10" -> 10. 2 < 10.
+    assert result4 == [{"code": "2"}, {"code": "10"}]
+
+    # Case 5: Mixed numbers and strings that look like numbers
+    data5 = [{"code": 10}, {"code": "2"}]
+    result5 = JSONPath("$./(code)").parse(data5)
+    # "2" -> 2. 2 < 10.
+    assert result5 == [{"code": "2"}, {"code": 10}]
+
+    # Case 6: Missing keys (None)
+    # None vs int comparison in Python 3 raises TypeError
+    data6 = [{"code": 1}, {"other": 2}]
+    with pytest.raises(JSONPathTypeError):
+        JSONPath("$./(code)").parse(data6)