From b0d66c27fd93dabb2bce85d1d93e24c27d835fb5 Mon Sep 17 00:00:00 2001 From: Steven Atkinson Date: Wed, 18 Feb 2026 16:21:44 -0800 Subject: [PATCH 1/5] Add integration tests workflow for PRs Co-authored-by: Cursor --- .github/workflows/integration-tests.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/workflows/integration-tests.yml diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml new file mode 100644 index 0000000..4905cd9 --- /dev/null +++ b/.github/workflows/integration-tests.yml @@ -0,0 +1,12 @@ +name: Run Integration Tests + +on: + pull_request: + branches: [main, integration-tests] + +jobs: + call-integration-tests: + uses: Atkinson-Advanced-Modeling/NamIntegrationTests/.github/workflows/integration-tests.yml@main + with: + source_repo: NeuralAmpModelerCore + ref: ${{ github.event.pull_request.head.sha }} From ceb05abdb29b653c76cf35ccb370d87d7f78a568 Mon Sep 17 00:00:00 2001 From: Steven Atkinson Date: Wed, 18 Feb 2026 17:01:50 -0800 Subject: [PATCH 2/5] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bc29bb0..0c301cf 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ For an example how to use, see [NeuralAmpModelerPlugin](https://github.com/sdatk ## Included Tools -There are a couple tools that exist to help you use this repo. +This repo includes a few helpful tools. For guidance on building them, have a look at the workflow provided in `.github/workflows/build.yml`. * [`run_tests`](https://github.com/sdatkinson/NeuralAmpModelerCore/blob/761fa968766bcf67d3035320c195969d9ba41fa1/tools/CMakeLists.txt#L15), which runs a suite of unit tests. From 7990284db093d5a88bde0d9be21b1385e50c1936 Mon Sep 17 00:00:00 2001 From: Steven Atkinson Date: Wed, 18 Feb 2026 17:31:32 -0800 Subject: [PATCH 3/5] Fix grammar in README example sentence --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0c301cf..f94ea3f 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Core C++ DSP library for NAM plugins. -For an example how to use, see [NeuralAmpModelerPlugin](https://github.com/sdatkinson/NeuralAmpModelerPlugin). +For an example of how to use, see [NeuralAmpModelerPlugin](https://github.com/sdatkinson/NeuralAmpModelerPlugin). ## Included Tools From d1b8bdcbdc06587985f6727e3521f9036a4a3904 Mon Sep 17 00:00:00 2001 From: Steven Atkinson Date: Wed, 18 Feb 2026 17:35:23 -0800 Subject: [PATCH 4/5] Fix typos in test_activations.cpp header comment --- tools/test/test_activations.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/test/test_activations.cpp b/tools/test/test_activations.cpp index 55d61ff..fce7fcf 100644 --- a/tools/test/test_activations.cpp +++ b/tools/test/test_activations.cpp @@ -1,7 +1,7 @@ // Tests for activation functions // -// Things you want ot test for: -// 1. That the core elementwise funciton is snapshot-correct. +// Things you want to test for: +// 1. That the core elementwise function is snapshot-correct. // 2. The class that wraps the core function for an array of data // 3. .cpp: that you have the singleton defined, and that it's in the unordered map to get by string From ea6e613cadfab89241c19e7e795546c40c88f092 Mon Sep 17 00:00:00 2001 From: Steven Atkinson Date: Wed, 18 Feb 2026 18:03:27 -0800 Subject: [PATCH 5/5] Fix grammar in run_tests.cpp comment --- tools/run_tests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/run_tests.cpp b/tools/run_tests.cpp index 8458f5c..3027bc0 100644 --- a/tools/run_tests.cpp +++ b/tools/run_tests.cpp @@ -1,5 +1,5 @@ // Entry point for tests -// See the GitHub Action for a demo how to build and run tests. +// See the GitHub Action for a demo of how to build and run tests. #include #include "test/test_activations.cpp"