Skip to content

Commit 5492978

Browse files
authored
perf: prevent large payload bytes print (#70)
1 parent afa161a commit 5492978

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

encoding/codecv7.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,13 @@ func (d *DACodecV7) checkCompressedDataCompatibility(payloadBytes []byte, checkL
240240
}
241241

242242
if err = checkCompressedDataCompatibilityV7(compressedPayloadBytes); err != nil {
243-
log.Warn("Compressed data compatibility check failed", "err", err, "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
243+
log.Warn("Compressed data compatibility check failed", "err", err, "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
244244
return nil, false, nil
245245
}
246246

247247
// check if compressed data is bigger or equal to the original data -> no need to compress
248248
if checkLength && len(compressedPayloadBytes) >= len(payloadBytes) {
249-
log.Warn("Compressed data is bigger or equal to the original data", "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
249+
log.Warn("Compressed data is bigger or equal to the original data", "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
250250
return nil, false, nil
251251
}
252252

encoding/codecv8.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ func (d *DACodecV8) checkCompressedDataCompatibility(payloadBytes []byte, checkL
5252
}
5353

5454
if err = checkCompressedDataCompatibilityV7(compressedPayloadBytes); err != nil {
55-
log.Warn("Compressed data compatibility check failed", "err", err, "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
55+
log.Warn("Compressed data compatibility check failed", "err", err, "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
5656
return nil, false, nil
5757
}
5858

5959
// check if compressed data is bigger or equal to the original data -> no need to compress
6060
if checkLength && len(compressedPayloadBytes) >= len(payloadBytes) {
61-
log.Warn("Compressed data is bigger or equal to the original data", "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
61+
log.Warn("Compressed data is bigger or equal to the original data", "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
6262
return nil, false, nil
6363
}
6464

encoding/codecv9.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@ func (d *DACodecV9) checkCompressedDataCompatibility(payloadBytes []byte, checkL
5151
}
5252

5353
if err = checkCompressedDataCompatibilityV9(compressedPayloadBytes); err != nil {
54-
log.Warn("Compressed data compatibility check failed", "err", err, "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
54+
log.Warn("Compressed data compatibility check failed", "err", err, "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
5555
return nil, false, nil
5656
}
5757

5858
// check if compressed data is bigger or equal to the original data -> no need to compress
5959
if checkLength && len(compressedPayloadBytes) >= len(payloadBytes) {
60-
log.Warn("Compressed data is bigger or equal to the original data", "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
60+
log.Warn("Compressed data is bigger or equal to the original data", "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
6161
return nil, false, nil
6262
}
6363

0 commit comments

Comments
 (0)