Do not create more clones than the maximum count

Author: adazem009

src/scratch/sprite.cpp

@@ -52,7 +52,7 @@ std::shared_ptr<Sprite> Sprite::clone()
 {
     IEngine *eng = engine();
 
-    if (eng) {
+    if (eng && (eng->cloneLimit() == -1 || eng->cloneCount() < eng->cloneLimit())) {
         std::shared_ptr<Sprite> clone = std::make_shared<Sprite>();
 
         if (impl->cloneRoot == nullptr)

test/blocks/control_blocks_test.cpp

@@ -904,6 +904,8 @@ TEST_F(ControlBlocksTest, CreateCloneOfImpl)
 
     Sprite *clone1;
     EXPECT_CALL(m_engineMock, targetAt(4)).WillOnce(Return(&sprite));
+    EXPECT_CALL(m_engineMock, cloneLimit()).Times(8).WillRepeatedly(Return(300));
+    EXPECT_CALL(m_engineMock, cloneCount()).Times(4).WillRepeatedly(Return(0));
     EXPECT_CALL(m_engineMock, initClone).WillOnce(SaveArg<0>(&clone1));
     EXPECT_CALL(m_engineMock, requestRedraw());
 
@@ -989,6 +991,8 @@ TEST_F(ControlBlocksTest, DeleteThisCloneImpl)
     sprite.setEngine(&m_engineMock);
 
     Sprite *clone;
+    EXPECT_CALL(m_engineMock, cloneLimit()).Times(2).WillRepeatedly(Return(300));
+    EXPECT_CALL(m_engineMock, cloneCount()).WillOnce(Return(0));
     EXPECT_CALL(m_engineMock, initClone(_)).WillOnce(SaveArg<0>(&clone));
     EXPECT_CALL(m_engineMock, requestRedraw());
     sprite.clone();

test/scratch_classes/sprite_test.cpp

@@ -124,8 +124,10 @@ TEST(SpriteTest, Clone)
     EngineMock engine;
     sprite->setEngine(&engine);
     EXPECT_CALL(engine, requestRedraw()).Times(2);
+    EXPECT_CALL(engine, cloneLimit()).Times(6).WillRepeatedly(Return(300)); // clone count limit is tested later
 
     Sprite *clone1;
+    EXPECT_CALL(engine, cloneCount()).WillOnce(Return(0));
     EXPECT_CALL(engine, initClone(_)).WillOnce(SaveArg<0>(&clone1));
     ASSERT_EQ(sprite->clone().get(), clone1);
     ASSERT_FALSE(sprite->isClone());
@@ -142,6 +144,7 @@ TEST(SpriteTest, Clone)
     sprite->setLayerOrder(3);
 
     Sprite *clone2;
+    EXPECT_CALL(engine, cloneCount()).WillOnce(Return(1));
     EXPECT_CALL(engine, initClone(_)).WillOnce(SaveArg<0>(&clone2));
     ASSERT_EQ(clone1->clone().get(), clone2);
     ASSERT_TRUE(clone1->isClone());
@@ -156,13 +159,23 @@ TEST(SpriteTest, Clone)
     sprite->setVisible(true);
 
     Sprite *clone3;
+    EXPECT_CALL(engine, cloneCount()).WillOnce(Return(2));
     EXPECT_CALL(engine, initClone(_)).WillOnce(SaveArg<0>(&clone3));
     ASSERT_EQ(clone1->clone().get(), clone3);
 
     Sprite *clone4;
+    EXPECT_CALL(engine, cloneLimit()).WillOnce(Return(-1));
     EXPECT_CALL(engine, initClone(_)).WillOnce(SaveArg<0>(&clone4));
     ASSERT_EQ(sprite->clone().get(), clone4);
 
+    EXPECT_CALL(engine, cloneLimit()).Times(2).WillRepeatedly(Return(0));
+    EXPECT_CALL(engine, cloneCount()).WillOnce(Return(0));
+    ASSERT_EQ(sprite->clone(), nullptr);
+
+    EXPECT_CALL(engine, cloneLimit()).Times(2).WillRepeatedly(Return(150));
+    EXPECT_CALL(engine, cloneCount()).WillOnce(Return(150));
+    ASSERT_EQ(sprite->clone(), nullptr);
+
     // children
     const auto &children1 = sprite->children();
     ASSERT_EQ(children1.size(), 2);

test/script/script_test.cpp

@@ -112,6 +112,8 @@ TEST_F(ScriptTest, Start)
     root.addVariable(var2);
     root.addList(list2);
 
+    EXPECT_CALL(m_engine, cloneLimit()).Times(2).WillRepeatedly(Return(300));
+    EXPECT_CALL(m_engine, cloneCount()).WillOnce(Return(0));
     EXPECT_CALL(m_engine, initClone).Times(1);
     EXPECT_CALL(m_engine, requestRedraw());
     auto clone = root.clone();

test/target_interfaces/ispritehandler_test.cpp

@@ -28,6 +28,8 @@ TEST_F(ISpriteHandlerTest, Clone)
 {
     Sprite *clone;
     Sprite *cloneArg;
+    EXPECT_CALL(m_engine, cloneLimit()).Times(2).WillRepeatedly(Return(300));
+    EXPECT_CALL(m_engine, cloneCount()).WillOnce(Return(0));
     EXPECT_CALL(m_engine, initClone(_)).WillOnce(SaveArg<0>(&clone));
     EXPECT_CALL(m_handler, onCloned(_)).WillOnce(SaveArg<0>(&cloneArg));
     EXPECT_CALL(m_engine, requestRedraw());