Merge pull request #177 from scratchcpp/fix_string_to_long

Fix string (with space separated numbers) to long conversion

Author: adazem009

include/scratchcpp/value.h

@@ -660,6 +660,14 @@ class LIBSCRATCHCPP_EXPORT Value : public ValueVariant
                 return 0;
             }
 
+            static const std::string digits = "0123456789+-";
+
+            for (char c : s) {
+                if (digits.find(c) == std::string::npos) {
+                    return 0;
+                }
+            }
+
             try {
                 if (ok)
                     *ok = true;

test/scratch_classes/value_test.cpp

@@ -123,6 +123,30 @@ TEST(ValueTest, StdStringConstructor)
         ASSERT_TRUE(v.isString());
     }
 
+    {
+        Value v(std::string("532"));
+        ASSERT_EQ(v.toString(), "532");
+        ASSERT_EQ(v.type(), Value::Type::Number);
+        ASSERT_FALSE(v.isInfinity());
+        ASSERT_FALSE(v.isNegativeInfinity());
+        ASSERT_FALSE(v.isNaN());
+        ASSERT_TRUE(v.isNumber());
+        ASSERT_FALSE(v.isBool());
+        ASSERT_FALSE(v.isString());
+    }
+
+    {
+        Value v(std::string("1 2 3"));
+        ASSERT_EQ(v.toString(), "1 2 3");
+        ASSERT_EQ(v.type(), Value::Type::String);
+        ASSERT_FALSE(v.isInfinity());
+        ASSERT_FALSE(v.isNegativeInfinity());
+        ASSERT_FALSE(v.isNaN());
+        ASSERT_FALSE(v.isNumber());
+        ASSERT_FALSE(v.isBool());
+        ASSERT_TRUE(v.isString());
+    }
+
     {
         Value v(std::string("Infinity"));
         ASSERT_EQ(v.toString(), "Infinity");