Skip to content

Commit 94906f9

Browse files
committed
Fix links for list/iter warning
1 parent 7a505c7 commit 94906f9

File tree

8 files changed

+25
-22
lines changed

8 files changed

+25
-22
lines changed

scrapinghub/client/activity.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ class Activity(_Proxy):
1111
instance to get a :class:`~scrapinghub.client.activity.Activity` instance.
1212
See :attr:`~scrapinghub.client.projects.Project.activity` attribute.
1313
14-
Please note that ``list()`` method can use a lot of memory and for a large
15-
amount of activities it's recommended to iterate through it via ``iter()``
14+
Please note that :meth:`list` method can use a lot of memory and for a large
15+
amount of activities it's recommended to iterate through it via :meth:`iter`
1616
method (all params and available filters are same for both methods).
1717
1818
Usage:

scrapinghub/client/collections.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,10 @@ def list(self, key=None, prefix=None, prefixcount=None, startts=None,
160160
endts=None, requests_params=None, **params):
161161
"""Convenient shortcut to list iter results.
162162
163-
Please note that ``list()`` method can use a lot of memory and for a
164-
large amount of elements it's recommended to iterate through it via
165-
``iter()`` method (all params and available filters are same for both
166-
methods).
163+
Please note that :meth:`list` method can use a lot of memory and for a
164+
large amount of logs it's recommended to iterate through it
165+
via :meth:`iter` method (all params and available filters are same for
166+
both methods).
167167
168168
:param key: a string key or a list of keys to filter with.
169169
:param prefix: a string prefix to filter items.

scrapinghub/client/items.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ class Items(_Proxy):
1010
e to get a :class:`Items` instance.
1111
See :attr:`~scrapinghub.client.jobs.Job.items` attribute.
1212
13-
Please note that ``list()`` method can use a lot of memory and for a large
14-
amount of items it's recommended to iterate through it via ``iter()`` method
15-
(all params and available filters are same for both methods).
13+
Please note that :meth:`list` method can use a lot of memory and for
14+
a large amount of logs it's recommended to iterate through it via
15+
:meth:`iter` method (all params and available filters are same for
16+
both methods).
1617
1718
Usage:
1819

scrapinghub/client/jobs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ def list(self, count=None, start=None, spider=None, state=None,
167167
:return: list of dictionaries of jobs summary for a given filter params.
168168
:rtype: :class:`list[dict]`
169169
170-
Please note that list() method can use a lot of memory and for a large
171-
amount of jobs it's recommended to iterate through it via iter()
170+
Please note that :meth:`list` can use a lot of memory and for a large
171+
amount of logs it's recommended to iterate through it via :meth:`iter`
172172
method (all params and available filters are same for both methods).
173173
"""
174174
# FIXME we double-check the params here, is there a better way?

scrapinghub/client/logs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ class Logs(_Proxy):
1212
to get a :class:`Logs` instance. See :attr:`~scrapinghub.client.jobs.Job.logs`
1313
attribute.
1414
15-
Please note that ``list()`` method can use a lot of memory and for a large
16-
amount of logs it's recommended to iterate through it via ``iter()`` method
17-
(all params and available filters are same for both methods).
15+
Please note that :meth:`list` method can use a lot of memory and for a
16+
large amount of logs it's recommended to iterate through it via :meth:`iter`
17+
method (all params and available filters are same for both methods).
1818
1919
Usage:
2020

scrapinghub/client/requests.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ class Requests(_Proxy):
1010
to get a :class:`Requests` instance.
1111
See :attr:`~scrapinghub.client.jobs.Job.requests` attribute.
1212
13-
Please note that ``list()`` method can use a lot of memory and for a large
14-
amount of requests it's recommended to iterate through it via ``iter()``
15-
method (all params and available filters are same for both methods).
13+
Please note that :meth:`list` method can use a lot of memory and for
14+
a large amount of logs it's recommended to iterate through it via
15+
:meth:`iter` method (all params and available filters are same for
16+
both methods).
1617
1718
Usage:
1819

scrapinghub/client/samples.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ class Samples(_Proxy):
1010
to get a :class:`Samples` instance.
1111
See :attr:`~scrapinghub.client.jobs.Job.samples` attribute.
1212
13-
Please note that ``list()`` method can use a lot of memory and for a large
14-
amount of samples it's recommended to iterate through it via ``iter()``
15-
method (all params and available filters are same for both methods).
13+
Please note that :meth:`list` method can use a lot of memory and for
14+
a large amount of logs it's recommended to iterate through it via
15+
:meth:`iter` method (all params and available filters are same for
16+
both methods).
1617
1718
Usage:
1819

scrapinghub/client/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ def _modify_iter_params(self, params):
145145
def list(self, *args, **kwargs):
146146
"""Convenient shortcut to list iter results.
147147
148-
Please note that ``list()`` method can use a lot of memory and for a
148+
Please note that :meth:`list` method can use a lot of memory and for a
149149
large amount of elements it's recommended to iterate through it via
150-
``iter()`` method (all params and available filters are same for both
150+
:meth:`iter` method (all params and available filters are same for both
151151
methods).
152152
"""
153153
return list(self.iter(*args, **kwargs))

0 commit comments

Comments
 (0)