Add more retries and extend retry time #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalessin
reviewed
Jun 29, 2021
Member
kalessin
left a comment
kalessin
left a comment
There was a problem hiding this comment.
This PR includes a commit that doesn't belong to the change proposed and conflicts with master. Can you clean it?
| slot_obj.flush() | ||
| self._links_to_flush_count[slot] = 0 | ||
| LOG.info('Flushed %d link(s) to slot %s', slot) | ||
| LOG.info('Flushed %d link(s) to slot %s', n_links_to_flush, slot) |
Member
There was a problem hiding this comment.
This fix doesn't apply anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting extension of retry times and retry time window for
HCFCrawlManager.This would be helpful in cases of short API downtimes (API is usually up in 10 minutes), otherwise the manager dies after 3 retries in 60 s.
Since the managers are supposed to run for days, it would be better if they survived occasional API downtime.