fix(_adb): avoid non-POSIX \? in BRE

akinomyoga · akinomyoga · commit 86f913455936 · 2023-05-02T04:54:34.000+09:00
POSIX Basic Regular Expressions (BRE) does not support \?.  Instead,
we can use \{0,1\}.  Also, `grep` and `sed` can be combined.
diff --git a/completions/_adb b/completions/_adb
@@ -5,9 +5,9 @@
 
 _comp_cmd_adb__command_usage()
 {
-    COMPREPLY=($(compgen -W \
-        '$("$1" help 2>&1 | command grep "^ *\(adb \)\? *$2 " \
-            | command sed -e "s/[]|[]/\n/g" | _parse_help -)' -- "$cur"))
+    COMPREPLY=($(compgen -W '$("$1" help 2>&1 | \
+            command sed -e "/^ *\(adb \)\{0,1\} *$2 /!d;s/[]|[]/\n/g" | \
+            _parse_help -)' -- "$cur"))
 }
 
 _comp_cmd_adb()

Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,9 @@`
`5`	`5`
`6`	`6`	`_comp_cmd_adb__command_usage()`
`7`	`7`	`{`
`8`		`- COMPREPLY=($(compgen -W \`
`9`		`- '$("$1" help 2>&1 \| command grep "^ \(adb \)\? $2 " \`
`10`		`- \| command sed -e "s/[]\|[]/\n/g" \| _parse_help -)' -- "$cur"))`
	`8`	`+ COMPREPLY=($(compgen -W '$("$1" help 2>&1 \| \`
	`9`	`+ command sed -e "/^ \(adb \)\{0,1\} $2 /!d;s/[]\|[]/\n/g" \| \`
	`10`	`+ _parse_help -)' -- "$cur"))`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`_comp_cmd_adb()`