fix(completions/*): quote other $split in misc contexts

Author: akinomyoga

completions/_mount.linux

@@ -24,7 +24,7 @@ _comp_cmd_mount()
                 proc qnx4 ramfs reiserfs romfs squashfs smbfs sysv tmpfs ubifs
                 udf ufs umsdos usbfs vfat xfs' -- "$cur"))
             _fstypes
-            $split && COMPREPLY=(${COMPREPLY[@]/#/$prev,})
+            "$split" && COMPREPLY=(${COMPREPLY[@]/#/$prev,})
             return
             ;;
         --bind | -B | --rbind | -R)
@@ -206,7 +206,7 @@ _comp_cmd_mount()
             esac
             # COMP_WORDBREAKS is a real pain in the ass
             prev="${prev##*["$COMP_WORDBREAKS"]}"
-            $split && COMPREPLY=(${COMPREPLY[@]/#/"$prev,"})
+            "$split" && COMPREPLY=(${COMPREPLY[@]/#/"$prev,"})
             [[ ${COMPREPLY-} == *= ]] && compopt -o nospace
             return
             ;;

completions/_umount.linux

@@ -113,7 +113,7 @@ _comp_cmd_umount()
                 ramfs reiserfs romfs squashfs smbfs sysv tmpfs ubifs udf ufs
                 umsdos usbfs vfat xfs' -- "$cur"))
             _fstypes
-            $split && COMPREPLY=(${COMPREPLY[@]/#/$prev,})
+            "$split" && COMPREPLY=(${COMPREPLY[@]/#/$prev,})
             return
             ;;
         -O)

completions/configure

@@ -20,7 +20,7 @@ _configure()
             ;;
     esac
 
-    if $split || [[ $cur != -* ]]; then
+    if "$split" || [[ $cur != -* ]]; then
         _filedir
         return
     fi

completions/cppcheck

@@ -26,7 +26,7 @@ _cppcheck()
             COMPREPLY=($(compgen -W 'all warning style performance
                 portability information unusedFunction missingInclude' \
                 -- "$cur"))
-            $split && COMPREPLY=(${COMPREPLY[@]/#/"$prev,"})
+            "$split" && COMPREPLY=(${COMPREPLY[@]/#/"$prev,"})
             return
             ;;
         --error-exitcode)
@@ -62,7 +62,7 @@ _cppcheck()
             return
             ;;
         -rp | --relative-paths)
-            if $split; then # -rp without argument is allowed
+            if "$split"; then # -rp without argument is allowed
                 _filedir -d
                 return
             fi

completions/idn

@@ -18,7 +18,7 @@ _idn()
             ;;
     esac
 
-    if ! $split && [[ $cur == -* ]]; then
+    if ! "$split" && [[ $cur == -* ]]; then
         COMPREPLY=($(compgen -W '$(_parse_help "$1")' -- "$cur"))
         [[ ${COMPREPLY-} == *= ]] && compopt -o nospace
     fi

completions/tar

@@ -603,7 +603,7 @@ _gtar()
                 # if there is some unknown option with '=', for example
                 # (literally) user does --nonexistent=<TAB>, we do not want
                 # continue also
-                $split && break
+                "$split" && break
 
                 # Most probably, when code goes here, the PREV variable contains
                 # some string from "$long_arg_none" and we want continue.