Address review feedback: remove unnecessary files and fix mutex limit handling

Copilot · bbockelm · Copilot · commit ca69f6c7fa35 · 2025-12-09T02:05:21.000Z
Co-authored-by: bbockelm &lt;1093447+bbockelm@users.noreply.github.com&gt;
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1 @@
 build
-_codeql_build_dir
diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root
diff --git a/src/scitokens_internal.cpp b/src/scitokens_internal.cpp
@@ -62,9 +62,10 @@ std::shared_ptr<std::mutex> get_issuer_mutex(const std::string &issuer) {
             }
         }
         
-        // If still at capacity after cleanup, allow creating this new mutex anyway
-        // The limit is a soft limit - we'll exceed it temporarily for active issuers
-        // This is better than either blocking or aggressively clearing the cache
+        // If still at capacity after cleanup, fail rather than unbounded growth
+        if (issuer_mutexes.size() >= MAX_ISSUER_MUTEXES) {
+            throw std::runtime_error("Too many concurrent issuers - resource exhaustion prevented");
+        }
     }
     
     auto mutex_ptr = std::make_shared<std::mutex>();

Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,10 @@ std::shared_ptr<std::mutex> get_issuer_mutex(const std::string &issuer) {`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`- // If still at capacity after cleanup, allow creating this new mutex anyway`
`66`		`- // The limit is a soft limit - we'll exceed it temporarily for active issuers`
`67`		`- // This is better than either blocking or aggressively clearing the cache`
	`65`	`+ // If still at capacity after cleanup, fail rather than unbounded growth`
	`66`	`+ if (issuer_mutexes.size() >= MAX_ISSUER_MUTEXES) {`
	`67`	`+ throw std::runtime_error("Too many concurrent issuers - resource exhaustion prevented");`
	`68`	`+ }`
`68`	`69`	`}`
`69`	`70`
`70`	`71`	`auto mutex_ptr = std::make_shared<std::mutex>();`