Remove unnecessary atomics for total_time_s since it's protected by mutex

Co-authored-by: bbockelm <1093447+bbockelm@users.noreply.github.com>

Author: Copilot

src/scitokens_internal.h

@@ -121,7 +121,7 @@ struct IssuerStats {
     std::atomic<uint64_t> successful_validations{0};
     std::atomic<uint64_t> unsuccessful_validations{0};
     std::atomic<uint64_t> expired_tokens{0};
-    std::atomic<double> total_time_s{0.0}; // Total time in seconds
+    double total_time_s{0.0}; // Total time in seconds - protected by mutex
 };
 
 /**

src/scitokens_monitoring.cpp

@@ -22,8 +22,8 @@ void MonitoringStats::record_validation_success(const std::string &issuer,
     auto &stats = m_issuer_stats[issuer];
     stats.successful_validations++;
     // Add to the total time (accumulate across all validations)
-    double current = stats.total_time_s.load();
-    stats.total_time_s.store(current + duration_s);
+    // No atomic needed - protected by mutex
+    stats.total_time_s += duration_s;
 }
 
 void MonitoringStats::record_validation_failure(const std::string &issuer,
@@ -32,8 +32,8 @@ void MonitoringStats::record_validation_failure(const std::string &issuer,
     auto &stats = m_issuer_stats[issuer];
     stats.unsuccessful_validations++;
     // Add to the total time (accumulate across all validations)
-    double current = stats.total_time_s.load();
-    stats.total_time_s.store(current + duration_s);
+    // No atomic needed - protected by mutex
+    stats.total_time_s += duration_s;
 }
 
 void MonitoringStats::record_expired_token(const std::string &issuer) {
@@ -115,7 +115,7 @@ std::string MonitoringStats::get_json() const {
         issuer_obj["expired_tokens"] =
             picojson::value(static_cast<double>(stats.expired_tokens.load()));
         issuer_obj["total_validation_time_s"] =
-            picojson::value(stats.total_time_s.load());
+            picojson::value(stats.total_time_s);
 
         std::string sanitized_issuer = sanitize_issuer_for_json(issuer);
         issuers_obj[sanitized_issuer] = picojson::value(issuer_obj);