Refactor monitoring code per code review feedback

Co-authored-by: bbockelm <1093447+bbockelm@users.noreply.github.com>

Author: Copilot

src/scitokens_internal.h

@@ -495,32 +495,20 @@ class Validator {
 
                 result = verify_async_continue(std::move(result));
             }
-        } catch (const std::exception &e) {
-            // Record failure if we have an issuer
+            
+            // Record successful validation
             if (has_issuer) {
                 auto end_time = std::chrono::steady_clock::now();
                 auto duration = std::chrono::duration_cast<std::chrono::nanoseconds>(
                     end_time - start_time);
-                
-                std::string error_msg = e.what();
-                
-                // Check if this is a failed issuer lookup (network/DNS errors)
-                if (error_msg.find("resolve") != std::string::npos ||
-                    error_msg.find("host") != std::string::npos ||
-                    error_msg.find("network") != std::string::npos ||
-                    error_msg.find("Failed to retrieve") != std::string::npos) {
-                    internal::MonitoringStats::instance().record_failed_issuer_lookup(issuer);
-                }
-                
-                // Check if this is an expiration error
-                if (error_msg.find("exp") != std::string::npos ||
-                    error_msg.find("expir") != std::string::npos) {
-                    internal::MonitoringStats::instance().record_expired_token(issuer);
-                }
-                
-                internal::MonitoringStats::instance().record_validation_failure(
+                internal::MonitoringStats::instance().record_validation_success(
                     issuer, duration.count());
             }
+        } catch (const std::exception &e) {
+            // Record failure if we have an issuer
+            if (has_issuer) {
+                record_validation_error(issuer, e, start_time);
+            }
             throw;
         }
     }
@@ -541,32 +529,20 @@ class Validator {
             while (!result->m_done) {
                 result = verify_async_continue(std::move(result));
             }
-        } catch (const std::exception &e) {
-            // Record failure if we have an issuer
+            
+            // Record successful validation
             if (has_issuer) {
                 auto end_time = std::chrono::steady_clock::now();
                 auto duration = std::chrono::duration_cast<std::chrono::nanoseconds>(
                     end_time - start_time);
-                
-                std::string error_msg = e.what();
-                
-                // Check if this is a failed issuer lookup (network/DNS errors)
-                if (error_msg.find("resolve") != std::string::npos ||
-                    error_msg.find("host") != std::string::npos ||
-                    error_msg.find("network") != std::string::npos ||
-                    error_msg.find("Failed to retrieve") != std::string::npos) {
-                    internal::MonitoringStats::instance().record_failed_issuer_lookup(issuer);
-                }
-                
-                // Check if this is an expiration error
-                if (error_msg.find("exp") != std::string::npos ||
-                    error_msg.find("expir") != std::string::npos) {
-                    internal::MonitoringStats::instance().record_expired_token(issuer);
-                }
-                
-                internal::MonitoringStats::instance().record_validation_failure(
+                internal::MonitoringStats::instance().record_validation_success(
                     issuer, duration.count());
             }
+        } catch (const std::exception &e) {
+            // Record failure if we have an issuer
+            if (has_issuer) {
+                record_validation_error(issuer, e, start_time);
+            }
             throw;
         }
     }
@@ -947,6 +923,36 @@ class Validator {
         }
     }
 
+    /**
+     * Helper method to record monitoring statistics for validation errors.
+     */
+    void record_validation_error(const std::string &issuer,
+                                  const std::exception &e,
+                                  const std::chrono::steady_clock::time_point &start_time) {
+        auto end_time = std::chrono::steady_clock::now();
+        auto duration = std::chrono::duration_cast<std::chrono::nanoseconds>(
+            end_time - start_time);
+        
+        std::string error_msg = e.what();
+        
+        // Check if this is a failed issuer lookup (network/DNS errors)
+        if (error_msg.find("resolve") != std::string::npos ||
+            error_msg.find("host") != std::string::npos ||
+            error_msg.find("network") != std::string::npos ||
+            error_msg.find("Failed to retrieve") != std::string::npos) {
+            internal::MonitoringStats::instance().record_failed_issuer_lookup(issuer);
+        }
+        
+        // Check if this is an expiration error
+        if (error_msg.find("exp") != std::string::npos ||
+            error_msg.find("expir") != std::string::npos) {
+            internal::MonitoringStats::instance().record_expired_token(issuer);
+        }
+        
+        internal::MonitoringStats::instance().record_validation_failure(
+            issuer, duration.count());
+    }
+
     bool m_validate_all_claims{true};
     SciToken::Profile m_profile{SciToken::Profile::COMPAT};
     SciToken::Profile m_validate_profile{SciToken::Profile::COMPAT};