Skip to content

[MAGIC] Transformation resolving using vertices instead of pixel offsets. #585

@YooSunYoung

Description

@YooSunYoung

The position vectors are zipped assuming there is x_pixel_offset but MAGIC decided not to have any pixel offsets in the file.
So the assumption that x_pixel_offset will always be present is now wrong.

https://github.com/scipp/scippnexus/blob/3550be53b4cb1897e82082400651fecd4a87fc58/src/scippnexus/nxtransformations.py#L493-L520

I asked Iurii in person and MAGIC defines each pixel's 8 voxels positions respect to the sample directly, which will always stay the same in terms of relative position (x, y, z). The only thing that changes is the scattering angle.

Then we need to skip the pixel offset and difectly use the voxel positions...?
i.e. if there are no pixel positions in the file, we just use position of the vertices.
@MridulS Do you maybe have more context on this...?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions