feat: store API keys in the system keyring

Author: bendrucker

.github/workflows/ci.yaml

@@ -27,7 +27,7 @@ jobs:
         run: deno task check
 
       - name: Run tests
-        run: deno task test
+        run: deno task test --ignore=test/keyring.integration.test.ts
 
       - name: Install linear-cli for skill generation
         run: deno task install
@@ -43,3 +43,28 @@ jobs:
             git diff skills/
             exit 1
           fi
+
+  keyring-integration:
+    strategy:
+      matrix:
+        include:
+          - os: macos-latest
+          - os: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: denoland/setup-deno@v2
+        with:
+          deno-version: v2.x
+
+      - name: Set up Secret Service
+        if: runner.os == 'Linux'
+        run: |
+          sudo apt-get update && sudo apt-get install -y gnome-keyring libsecret-tools dbus-x11
+          eval "$(dbus-launch --sh-syntax)"
+          echo "DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS" >> $GITHUB_ENV
+          echo "test-password" | gnome-keyring-daemon --unlock --components=secrets
+
+      - name: Keyring Integration
+        run: deno task test test/keyring.integration.test.ts

src/commands/auth/auth-list.ts

@@ -2,12 +2,12 @@ import { Command } from "@cliffy/command"
 import { unicodeWidth } from "@std/cli"
 import { gql } from "../../__codegen__/gql.ts"
 import {
-  getAllCredentials,
+  getApiKeyForWorkspace,
   getDefaultWorkspace,
   getWorkspaces,
 } from "../../credentials.ts"
 import { padDisplay } from "../../utils/display.ts"
-import { handleError } from "../../utils/errors.ts"
+import { handleError, isClientError } from "../../utils/errors.ts"
 import { createGraphQLClient } from "../../utils/graphql.ts"
 
 const viewerQuery = gql(`
@@ -48,11 +48,22 @@ async function fetchWorkspaceInfo(
       userName: result.viewer.name,
       email: result.viewer.email,
     }
-  } catch {
+  } catch (error) {
+    let errorMsg = "unknown error"
+    if (isClientError(error)) {
+      const status = error.response?.status
+      if (status === 401 || status === 403) {
+        errorMsg = "invalid credentials"
+      } else {
+        errorMsg = error.message
+      }
+    } else if (error instanceof Error) {
+      errorMsg = error.message
+    }
     return {
       workspace,
       isDefault,
-      error: "invalid credentials",
+      error: errorMsg,
     }
   }
 }
@@ -70,12 +81,19 @@ export const listCommand = new Command()
         return
       }
 
-      const credentials = getAllCredentials()
-
       // Fetch info for all workspaces in parallel
-      const infoPromises = workspaces.map((ws) =>
-        fetchWorkspaceInfo(ws, credentials[ws]!)
-      )
+      const infoPromises = workspaces.map((ws) => {
+        const apiKey = getApiKeyForWorkspace(ws)
+        if (apiKey == null) {
+          const info: WorkspaceInfo = {
+            workspace: ws,
+            isDefault: getDefaultWorkspace() === ws,
+            error: "missing credentials",
+          }
+          return Promise.resolve(info)
+        }
+        return fetchWorkspaceInfo(ws, apiKey)
+      })
       const infos = await Promise.all(infoPromises)
 
       // Calculate column widths