small code changes

Author: mscasso-scanoss

CHANGELOG.md

@@ -5,11 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [1.6.6] - 2026-04-07
 ### Added
 - Added configurable file contents size limit (`SCANOSS_FILE_CONTENTS_LIMIT`).
   - Limits the maximum file size returned by the `file_contents` endpoint (default: 50 MB).
-  - Returns HTTP 400 when the file exceeds the configured limit.
+  - Returns HTTP 400 with the error `file contents size exceeds` when the file exceeds the configured limit.
 
 ## [1.6.5] - 2026-03-26
 ### Fixed

pkg/service/filecontents_service.go

@@ -82,10 +82,12 @@ func (s APIService) FileContents(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, "ERROR recovering file contents", http.StatusInternalServerError)
 		return
 	}
+	// convert the configured limit from MB to bytes.
 	limitBytes := s.config.Scanning.FileContentsLimit * 1024 * 1024
+	outputLen := int64(len(output))
 	// unlimited for FileContentsLimit <= 0
-	if limitBytes > 0 && int64(len(output)) > limitBytes {
-		zs.Warnf("File contents size %d bytes exceeds limit %d MB for md5 %s", len(output), s.config.Scanning.FileContentsLimit, md5)
+	if limitBytes > 0 && outputLen > limitBytes {
+		zs.Warnf("File contents size %d bytes exceeds limit %d MB for md5 %s", outputLen, s.config.Scanning.FileContentsLimit, md5)
 		w.Header().Set(ContentTypeKey, ApplicationJSON)
 		w.WriteHeader(http.StatusRequestEntityTooLarge)
 		resp := map[string]string{
@@ -97,13 +99,13 @@ func (s APIService) FileContents(w http.ResponseWriter, r *http.Request) {
 	}
 	charset := detectCharset(output)
 	if s.config.App.Trace {
-		zs.Debugf("Sending back contents: %v - '%s'", len(output), output)
+		zs.Debugf("Sending back contents: %v - '%s'", outputLen, output)
 	} else {
-		zs.Debugf("Sending back contents: %v", len(output))
+		zs.Debugf("Sending back contents: %v", outputLen)
 	}
 	w.Header().Set(ContentTypeKey, fmt.Sprintf("text/plain; charset=%s", charset))
 	w.Header().Set(CharsetDetectedKey, charset)
-	w.Header().Set(ContentLengthKey, fmt.Sprintf("%d", len(output)))
+	w.Header().Set(ContentLengthKey, fmt.Sprintf("%d", outputLen))
 	printResponse(w, string(output), zs, false)
 }